[all-commits] [llvm/llvm-project] 06ca52: [InlineOrder] Fix InlineOrder erase_if implementat...

Vincent Lee via All-commits all-commits at lists.llvm.org
Sat Jan 20 14:22:43 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 06ca52e25226d406a3e384953abd12955f42ac84
      https://github.com/llvm/llvm-project/commit/06ca52e25226d406a3e384953abd12955f42ac84
  Author: Vincent Lee <thevinster at users.noreply.github.com>
  Date:   2024-01-20 (Sat, 20 Jan 2024)

  Changed paths:
    M llvm/lib/Analysis/InlineOrder.cpp

  Log Message:
  -----------
  [InlineOrder] Fix InlineOrder erase_if implementation (#78684)

The InlineOrder Heap stores a CallBase ptr and InlineHistoryID pair.
When running the `erase_if` method, InlineHistoryID is always returned
with 0. Instead, we should be retrieving it from the `InlineHistoryMap`
(similar to what is done in the `pop` implementation).

This change is completely harmless because no one is using
InlineHistoryID right now as part of the `erase_if` implementation which
is currently only used in the ModuleInliner.




More information about the All-commits mailing list