[all-commits] [llvm/llvm-project] d0d072: [lldb][test] Apply @expectedFailureAll/@skipIf ear...
Jordan Rupprecht via All-commits
all-commits at lists.llvm.org
Fri Jan 19 08:50:16 PST 2024
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: d0d072710468316edbd4130e50f1146c5a6aca89
https://github.com/llvm/llvm-project/commit/d0d072710468316edbd4130e50f1146c5a6aca89
Author: Jordan Rupprecht <rupprecht at google.com>
Date: 2024-01-19 (Fri, 19 Jan 2024)
Changed paths:
M lldb/packages/Python/lldbsuite/test/decorators.py
M lldb/packages/Python/lldbsuite/test/lldbtest.py
M lldb/test/API/test_utils/TestDecorators.py
Log Message:
-----------
[lldb][test] Apply @expectedFailureAll/@skipIf early for debug_info tests (#73067)
The @expectedFailureAll and @skipIf decorators will mark the test case
as xfail/skip if _all_ conditions passed in match, including debug_info.
* If debug_info is not one of the matching conditions, we can
immediately evaluate the check and decide if it should be decorated.
* If debug_info *is* present as a match condition, we need to defer
whether or not to decorate until when the `LLDBTestCaseFactory`
metaclass expands the test case into its potential variants. This is
still early enough that the standard `unittest` framework will recognize
the test as xfail/skip by the time the test actually runs.
TestDecorators exhibits the edge cases more thoroughly. With the
exception of `@expectedFailureIf` (added by this commit), all those test
cases pass prior to this commit.
This is a followup to 212a60ec37322f853e91e171b305479b1abff2f2.
More information about the All-commits
mailing list