[all-commits] [llvm/llvm-project] 0266f4: [compiler-rt] Drop COMPILER_RT_BUILD_CRT workaroun...

[Alexander Richardson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0266f414f624ebd74f8607ebd3ac94bbb93b0ebb
      https://github.com/llvm/llvm-project/commit/0266f414f624ebd74f8607ebd3ac94bbb93b0ebb
  Author: Alexander Richardson <alexrichardson at google.com>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M compiler-rt/lib/builtins/CMakeLists.txt

  Log Message:
  -----------
  [compiler-rt] Drop COMPILER_RT_BUILD_CRT workaround (#78331)

This variable was explicitly removed from the cache to ease transition
from existing build directories but that breaks passing
COMPILER_RT_BUILD_CRT=OFF on the command line. I was surprised to see
the CRT builds being run for my builtins-only build config (I noticed
because one of the tests was failing despite having `REQUIRES: crt`).

If I pass `-DCOMPILER_RT_BUILD_CRT=OFF` to cmake and add some prints
around the `unset` statement it shows the following:
```
-- before unset(): COMPILER_RT_BUILD_CRT=OFF
-- after unset: COMPILER_RT_BUILD_CRT=
-- after cmake_dependent_option COMPILER_RT_BUILD_CRT=ON
```

Drop this temporary workaround now that over 6 months have passed.