[all-commits] [llvm/llvm-project] a02a0e: [mlir][Transforms] `GreedyPatternRewriteDriver`: B...

Matthias Springer via All-commits all-commits at lists.llvm.org
Mon Jan 15 23:55:37 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a02a0e806fab01f4cf4307443cdaed76a2488752
      https://github.com/llvm/llvm-project/commit/a02a0e806fab01f4cf4307443cdaed76a2488752
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-01-16 (Tue, 16 Jan 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

  Log Message:
  -----------
  [mlir][Transforms] `GreedyPatternRewriteDriver`: Better expensive checks encapsulation (#78175)

This change moves most IR verification logic (which is part of the
expensive checks) into `DebugFingerPrints` and renames the struct to
`ExpensiveChecks`. This isolates the debugging logic better from the
remaining code.

This commit also removes a redundant check: the IR is no longer verified
after a failed pattern application. We already assert that the IR did
not change. (We know that the IR was valid before the attempted pattern
application.)




More information about the All-commits mailing list