[all-commits] [llvm/llvm-project] 844f83: Fix crash with modules and constexpr destructor (#...

[Jonas Hahnfeld via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 844f8335f211da19ae4b375761013909a3394d9a
      https://github.com/llvm/llvm-project/commit/844f8335f211da19ae4b375761013909a3394d9a
  Author: Jonas Hahnfeld <jonas.hahnfeld at cern.ch>
  Date:   2024-01-15 (Mon, 15 Jan 2024)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/AST/ExprConstant.cpp
    A clang/test/Modules/pr68702.cpp

  Log Message:
  -----------
  Fix crash with modules and constexpr destructor (#69076)

With modules, serialization might omit the outer ExprWithCleanups
as it calls ParmVarDecl::getDefaultArg(). Complementary to fixing
this in a separate change, make the code more robust by adding a
FullExpressionRAII and avoid the llvm_unreachable in the added test
clang/test/Modules/pr68702.cpp.

Closes https://github.com/llvm/llvm-project/issues/68702