[all-commits] [llvm/llvm-project] fc6faa: [CloneFunction][DebugInfo] Avoid cloning DILocalVa...

[Vladislav Dzhidzhoev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fc6faa1113e9069f41b5500db051210af0eea843
      https://github.com/llvm/llvm-project/commit/fc6faa1113e9069f41b5500db051210af0eea843
  Author: Vladislav Dzhidzhoev <vdzhidzhoev at accesssoftek.com>
  Date:   2024-01-11 (Thu, 11 Jan 2024)

  Changed paths:
    M clang/test/CodeGen/debug-info-codeview-unnamed.c
    M clang/test/CodeGen/debug-info-unused-types.c
    M clang/test/CodeGen/debug-info-unused-types.cpp
    M clang/test/CodeGenCXX/debug-info-access.cpp
    M clang/test/CodeGenCXX/debug-info-anon-union-vars.cpp
    M clang/test/CodeGenCXX/debug-info-codeview-unnamed.cpp
    M clang/test/CodeGenCXX/debug-info-gline-tables-only-codeview.cpp
    M clang/test/CodeGenCXX/debug-lambda-this.cpp
    M llvm/include/llvm/IR/DIBuilder.h
    M llvm/include/llvm/IR/DebugInfo.h
    M llvm/lib/Bitcode/Reader/MetadataLoader.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/IR/DIBuilder.cpp
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/lib/Transforms/Utils/CloneFunction.cpp
    A llvm/test/Bitcode/clone-local-types.ll
    M llvm/test/Bitcode/upgrade-cu-locals.ll
    M llvm/test/Bitcode/upgrade-cu-locals.ll.bc
    A llvm/test/DebugInfo/Generic/inlined-local-type.ll
    A llvm/test/DebugInfo/Generic/lexical-block-retained-types.ll
    A llvm/test/DebugInfo/Generic/lexical-block-types.ll
    R llvm/test/DebugInfo/Generic/split-dwarf-local-import.ll
    R llvm/test/DebugInfo/Generic/split-dwarf-local-import2.ll
    R llvm/test/DebugInfo/Generic/split-dwarf-local-import3.ll
    M llvm/test/DebugInfo/Generic/verifier-invalid-disubprogram.ll
    A llvm/test/DebugInfo/X86/local-type-as-template-parameter.ll
    M llvm/test/DebugInfo/X86/set.ll
    A llvm/test/DebugInfo/X86/split-dwarf-local-import.ll
    A llvm/test/DebugInfo/X86/split-dwarf-local-import2.ll
    A llvm/test/DebugInfo/X86/split-dwarf-local-import3.ll
    M llvm/unittests/Transforms/Utils/CloningTest.cpp

  Log Message:
  -----------
  [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (#75385)

- [DebugMetadata][DwarfDebug] Support function-local types in lexical
block scopes (4/7)
- [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined
functions

This is a follow-up for https://reviews.llvm.org/D144006, fixing a crash
reported
in Chromium (https://reviews.llvm.org/D144006#4651955).

The first commit is added for convenience, as it has already been
accepted.

If DISubpogram was not cloned (e.g. we are cloning a function that has
other
functions inlined into it, and subprograms of the inlined functions are
not supposed to be cloned), it doesn't make sense to clone its
DILocalVariables as well.
Otherwise get duplicated DILocalVariables not tracked in their
subprogram's retainedNodes, that crash LTO with Chromium.

This is meant to be committed along with
https://reviews.llvm.org/D144006.