[all-commits] [llvm/llvm-project] f972e4: [MC, ELF] .section: unconditionally print section f...

Fangrui Song via All-commits all-commits at lists.llvm.org
Tue Jan 9 10:48:41 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f972e4d3434364718899f974e4d1c8e60aea91fa
      https://github.com/llvm/llvm-project/commit/f972e4d3434364718899f974e4d1c8e60aea91fa
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-01-09 (Tue, 09 Jan 2024)

  Changed paths:
    M llvm/lib/MC/MCSectionELF.cpp
    M llvm/test/CodeGen/Mips/ehframe-indirect.ll
    M llvm/test/CodeGen/PowerPC/ppc32-pic-large.ll
    M llvm/test/CodeGen/SPARC/constructor.ll
    M llvm/test/CodeGen/X86/constructor.ll
    M llvm/test/CodeGen/X86/elf-comdat.ll
    M llvm/test/CodeGen/X86/elf-comdat2.ll
    M llvm/test/CodeGen/X86/elf-group.ll
    M llvm/test/CodeGen/X86/explicit-section-mergeable.ll
    M llvm/test/CodeGen/X86/global-sections-comdat.ll
    M llvm/test/DebugInfo/SystemZ/eh_frame_personality.ll
    M llvm/test/DebugInfo/SystemZ/eh_frame_personality.s
    M llvm/test/ExecutionEngine/JITLink/x86-64/ELF_ehframe_basic.s
    M llvm/test/ExecutionEngine/JITLink/x86-64/ELF_ehframe_large_static_personality_encodings.s
    M llvm/test/MC/ELF/alias-to-local.s
    M llvm/test/MC/ELF/relocation.s
    M llvm/test/tools/llvm-symbolizer/frame.s

  Log Message:
  -----------
  [MC,ELF] .section: unconditionally print section flag 'G' after 'o'

* Placing 'G' before 'M' (SHF_MERGE) can be misleading as the sh_entsize
  argument goes before the section group name, if a reader doesn't know
  that the order of extra arguments is not affected by the order of flags.
* 'a', 'w', and 'x' indicate basic permission-related flags. Separating
  them with 'G' is kinda ugly.

Simplify code and move 'G' after 'o'. The new output is more similar to
GCC.




More information about the All-commits mailing list