[all-commits] [llvm/llvm-project] acbb49: [libcxx] Require qemu-system-arm for armv7m builde...

David Spickett via All-commits all-commits at lists.llvm.org
Mon Jan 8 00:55:52 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: acbb491ab23fd04e201b58195f78e04c5a647d47
      https://github.com/llvm/llvm-project/commit/acbb491ab23fd04e201b58195f78e04c5a647d47
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2024-01-08 (Mon, 08 Jan 2024)

  Changed paths:
    M libcxx/cmake/caches/Armv7M-picolibc.cmake
    M libcxx/utils/qemu_baremetal.py

  Log Message:
  -----------
  [libcxx] Require qemu-system-arm for armv7m builder (#77067)

And add a check in the python script that the binary given to `--qemu`
actually exists. Otherwise you get a generic Python error:
```
 # .---command stderr------------
 # | Traceback (most recent call last):
 # |   File "/home/david.spickett/modules-llvm-project/libcxx/utils/qemu_baremetal.py", line 70, in <module>
 # |     exit(main())
 # |   File "/home/david.spickett/modules-llvm-project/libcxx/utils/qemu_baremetal.py", line 66, in main
 # |     os.execvp(qemu_commandline[0], qemu_commandline)
 # |   File "/usr/lib/python3.8/os.py", line 568, in execvp
 # |     _execvpe(file, args)
 # |   File "/usr/lib/python3.8/os.py", line 610, in _execvpe
 # |     raise last_exc
 # |   File "/usr/lib/python3.8/os.py", line 601, in _execvpe
 # |     exec_func(fullname, *argrest)
 # | FileNotFoundError: [Errno 2] No such file or directory
 # `-----------------------------
 # error: command failed with exit status: 1
```
When it tries to run the entire command later.

For the builder, it's only ever going to use qemu-system-arm so error at
config time if it's not there.




More information about the All-commits mailing list