[all-commits] [llvm/llvm-project] 38228d: [libc] Fix GPU tests not running after recent patc...

Joseph Huber via All-commits all-commits at lists.llvm.org
Sun Jan 7 11:33:29 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 38228d5efe18cbe45ea02ebb08b2d2a7e4b68560
      https://github.com/llvm/llvm-project/commit/38228d5efe18cbe45ea02ebb08b2d2a7e4b68560
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-01-07 (Sun, 07 Jan 2024)

  Changed paths:
    M libc/cmake/modules/LLVMLibCTestRules.cmake
    M libc/include/CMakeLists.txt
    M libc/src/__support/StringUtil/CMakeLists.txt

  Log Message:
  -----------
  [libc] Fix GPU tests not running after recent patches (#77248)

Summary:
A previous patch added a dependency on the stack protectors, this was
not built on the GPU targets so every test was disabled. It turns out
that disabled tests still get targets so we need to specifically check
if the it is in the target's set of entrypoints before we can use it.

Another patch, because the build-bot was down, snuck in that prevented
the new math tests from being run. The problem is that the `signal.h`
header requires target specific definitions but was being used
unconditionally. I have made changes that disable building this header
if the file is not defined in the config. This required disbaling the
signal_to_string utility, so that will simply be missing from targets
that don't define it.




More information about the All-commits mailing list