[all-commits] [llvm/llvm-project] c63feb: [mlir][spirv] Use assemblyFormat to define atomic ...

[Alex Beloi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c63febb1025564b078a5c8e52e6df638e8a1d808
      https://github.com/llvm/llvm-project/commit/c63febb1025564b078a5c8e52e6df638e8a1d808
  Author: Alex Beloi <alexbeloi at users.noreply.github.com>
  Date:   2024-01-06 (Sat, 06 Jan 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/SPIRV/IR/SPIRVAtomicOps.td
    M mlir/lib/Dialect/SPIRV/IR/AtomicOps.cpp
    M mlir/test/Conversion/MemRefToSPIRV/alloc.mlir
    M mlir/test/Conversion/MemRefToSPIRV/atomic.mlir
    M mlir/test/Conversion/MemRefToSPIRV/bitwidth-emulation.mlir
    M mlir/test/Dialect/SPIRV/IR/atomic-ops.mlir
    M mlir/test/Dialect/SPIRV/IR/availability.mlir
    M mlir/test/Dialect/SPIRV/IR/target-env.mlir
    M mlir/test/Dialect/SPIRV/Transforms/inlining.mlir
    M mlir/test/Target/SPIRV/atomic-ops.mlir
    M mlir/test/Target/SPIRV/debug.mlir

  Log Message:
  -----------
  [mlir][spirv] Use assemblyFormat to define atomic op assembly (#76323)

see #73359

Declarative assemblyFormat ODS is more concise and requires less
boilerplate than filling out CPP interfaces.

Changes:
* updates the Ops defined in `SPIRVAtomicOps.td` to use assemblyFormat.
* Removes print/parse from`AtomcOps.cpp` which is now generated by
assemblyFormat
* Adds `Trait` to verify that a pointer operand `foo`'s pointee type
matches operand `bar`'s type
* * Updates error message expected in tests from new Trait
* Updates tests to updated format (largely using <operand> in place of
"operand")