[all-commits] [llvm/llvm-project] 1c43e6: [CodeGen] Port `ShadowStackGCLowering` to new pass...

paperchalice via All-commits all-commits at lists.llvm.org
Fri Jan 5 17:25:29 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c43e64d7072bba3e6199999184f8323045684ac
      https://github.com/llvm/llvm-project/commit/1c43e64d7072bba3e6199999184f8323045684ac
  Author: paperchalice <liujunchang97 at outlook.com>
  Date:   2024-01-06 (Sat, 06 Jan 2024)

  Changed paths:
    M llvm/include/llvm/CodeGen/CodeGenPassBuilder.h
    M llvm/include/llvm/CodeGen/MachinePassRegistry.def
    A llvm/include/llvm/CodeGen/ShadowStackGCLowering.h
    M llvm/lib/CodeGen/ShadowStackGCLowering.cpp
    M llvm/lib/Passes/PassBuilder.cpp
    M llvm/lib/Passes/PassRegistry.def

  Log Message:
  -----------
  [CodeGen] Port `ShadowStackGCLowering` to new pass manager (#75324)

IIUC the new pass system was designed with parallelism. This pass needs
to add some global variables into the current module, this is not
allowed by

[WritingAnLLVMPass](https://llvm.org/docs/WritingAnLLVMPass.html#the-functionpass-class),
so convert it to module pass, see FIXME in `GetFrameMap`.

Therefore, this will trigger assertion in `CodeGenPassBuilder`:
https://github.com/llvm/llvm-project/blob/effd47ed45e3badd756103346a7c3b9e1e939e5e/llvm/include/llvm/CodeGen/CodeGenPassBuilder.h#L200-L207
Will fix it in future.




More information about the All-commits mailing list