[all-commits] [llvm/llvm-project] a89141: [clang-tidy] Add check `readability-avoid-return-w...

Fri Jan 5 16:58:54 PST 2024

  Branch: refs/heads/users/vitalybuka/spr/ubsan-drop-terminal-in-from-reports-without-functions
  Home:   https://github.com/llvm/llvm-project
  Commit: a89141f733cef817c586bb6da0ea69a5a323874e
      https://github.com/llvm/llvm-project/commit/a89141f733cef817c586bb6da0ea69a5a323874e
  Author: Danny Mösch <danny.moesch at icloud.com>
  Date:   2024-01-06 (Sat, 06 Jan 2024)

  Changed paths:
    A clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.cpp
    A clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.h
    M clang-tools-extra/clang-tidy/readability/CMakeLists.txt
    M clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/docs/clang-tidy/checks/list.rst
    A clang-tools-extra/docs/clang-tidy/checks/readability/avoid-return-with-void-value.rst
    A clang-tools-extra/test/clang-tidy/checkers/readability/avoid-return-with-void-value.cpp

  Log Message:
  -----------
  [clang-tidy] Add check `readability-avoid-return-with-void-value` (#76249)

  Commit: a9c5bddc8f18926bac6dc224144a32512207bd38
      https://github.com/llvm/llvm-project/commit/a9c5bddc8f18926bac6dc224144a32512207bd38
  Author: LLVM GN Syncbot <llvmgnsyncbot at gmail.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/readability/BUILD.gn

  Log Message:
  -----------
  [gn build] Port a89141f733ce

  Commit: 08c5f1fede969e687e77d0508008682e5f188f49
      https://github.com/llvm/llvm-project/commit/08c5f1fede969e687e77d0508008682e5f188f49
  Author: Ben Langmuir <blangmuir at apple.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M bolt/lib/Rewrite/JITLinkLinker.cpp
    M llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
    M llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
    M llvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h
    M llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
    M llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp
    M llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
    M llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp
    M llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
    M llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
    M llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp

  Log Message:
  -----------
  [ORC] Add absoluteSymbolsLinkGraph to expose absolute symbols to platform (#77008)

Adds a function to create a LinkGraph of absolute symbols, and a
callback in dynamic library search generators to enable using it to
expose its symbols to the platform/orc runtime. This allows e.g. using
__orc_rt_run_program to run a precompiled function that was found via
dlsym. Ideally we would use this in llvm-jitlink's own search generator,
but it will require more work to align with the Process/Platform
JITDylib split, so not handled here.

As part of this change we need to handle LinkGraphs that only have
absolute symbols.

  Commit: def42537ee65fd5d309b7ab70a9ea4d32eb6aadd
      https://github.com/llvm/llvm-project/commit/def42537ee65fd5d309b7ab70a9ea4d32eb6aadd
  Author: Daniel Hoekwater <hoekwater at google.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M llvm/test/CodeGen/Generic/machine-function-splitter.ll

  Log Message:
  -----------
  [NFC][CodeGen][AArch64] Add tests for unconditional branch duplication

c9f3288 introduced unconditional branch deduplication for basic block
sections and machine function splitting, but it didn't add tests for
AArch64 since prior behavior crashed the test.

This change adds tests for AArch64 and has no functional change.

  Commit: 651a42ff65c3afc2a2ec6c7fc19009387757d686
      https://github.com/llvm/llvm-project/commit/651a42ff65c3afc2a2ec6c7fc19009387757d686
  Author: Lang Hames <lhames at gmail.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M llvm/include/llvm/ExecutionEngine/Orc/Core.h

  Log Message:
  -----------
  [ORC] Remove unused flag (PendingRemoval) from JITDylib symbol table.

  Commit: 5e54319b7be3e8aa035836098e0a9defc0a41c3a
      https://github.com/llvm/llvm-project/commit/5e54319b7be3e8aa035836098e0a9defc0a41c3a
  Author: Dimple Prajapati <dimpalben.r.prajapati at intel.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
    M mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
    M mlir/test/Dialect/SPIRV/IR/structure-ops.mlir
    M mlir/test/Target/SPIRV/global-variable.mlir

  Log Message:
  -----------
  [mlir][spirv] Support spec constants as GlobalVar initializer (#75660)

Changes include:

- spirv serialization and deserialization needs handling in cases when
GlobalVariableOp initializer is defined using spirv SpecConstant or
SpecConstantComposite op, currently even though it allows SpecConst, it
only looked up in for GlobalVariable Map to find initializer symbol
reference, change is fixing this and extending the support to
SpecConstantComposite as an initializer.
- Adds tests to make sure GlobalVariable can be initialized using
specialized constants.

---------

Co-authored-by: Lei Zhang <antiagainst at gmail.com>

  Commit: 4f215fdd62d3f014750339eab9a46946b6fb1c4a
      https://github.com/llvm/llvm-project/commit/4f215fdd62d3f014750339eab9a46946b6fb1c4a
  Author: Konstantin Varlamov <varconsteq at gmail.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M libcxx/include/__algorithm/pop_heap.h
    M libcxx/include/__algorithm/sift_down.h
    M libcxx/include/__algorithm/sort.h
    M libcxx/include/__charconv/to_chars_base_10.h
    M libcxx/include/__charconv/to_chars_integral.h
    M libcxx/include/__charconv/traits.h
    M libcxx/include/__chrono/parser_std_format_spec.h
    M libcxx/include/__config
    M libcxx/include/__filesystem/directory_iterator.h
    M libcxx/include/__filesystem/path_iterator.h
    M libcxx/include/__format/buffer.h
    M libcxx/include/__format/format_arg.h
    M libcxx/include/__format/formatter_bool.h
    M libcxx/include/__format/formatter_floating_point.h
    M libcxx/include/__format/formatter_integral.h
    M libcxx/include/__format/formatter_output.h
    M libcxx/include/__format/formatter_string.h
    M libcxx/include/__format/parser_std_format_spec.h
    M libcxx/include/__format/range_formatter.h
    M libcxx/include/__format/unicode.h
    M libcxx/include/__format/write_escaped.h
    M libcxx/include/__hash_table
    M libcxx/include/__iterator/advance.h
    M libcxx/include/__iterator/next.h
    M libcxx/include/__iterator/prev.h
    M libcxx/include/__random/negative_binomial_distribution.h
    M libcxx/include/__ranges/chunk_by_view.h
    M libcxx/include/__ranges/drop_while_view.h
    M libcxx/include/__ranges/filter_view.h
    M libcxx/include/__thread/thread.h
    M libcxx/include/__utility/exception_guard.h
    M libcxx/include/__utility/unreachable.h
    M libcxx/include/print
    M libcxx/include/regex
    M libcxx/include/set
    M libcxx/src/filesystem/error.h
    M libcxx/src/filesystem/format_string.h
    M libcxx/src/filesystem/posix_compat.h
    M libcxx/src/include/to_chars_floating_point.h
    M libcxx/src/memory_resource.cpp
    M libcxx/src/strstream.cpp
    M libcxx/src/system_error.cpp
    M libcxx/test/libcxx/utilities/assert.exception_guard.no_exceptions.pass.cpp
    M libcxx/test/std/utilities/utility/utility.unreachable/assert.unreachable.pass.cpp

  Log Message:
  -----------
  [libc++][hardening] Categorize more assertions. (#75918)

Also introduce `_LIBCPP_ASSERT_PEDANTIC` for assertions violating which
results in a no-op or other benign behavior, but which may nevertheless
indicate a bug in the invoking code.

  Commit: 4df566290751403f470fea3b27aa148ab1ddf144
      https://github.com/llvm/llvm-project/commit/4df566290751403f470fea3b27aa148ab1ddf144
  Author: hev <wangrui at loongson.cn>
  Date:   2024-01-06 (Sat, 06 Jan 2024)

  Changed paths:
    M clang/include/clang/AST/Attr.h
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/AttrDocs.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/Sema/SemaDeclAttr.cpp
    A clang/test/CodeGen/LoongArch/attributes.cpp
    A clang/test/Sema/attr-model.cpp

  Log Message:
  -----------
  [clang] Add per-global code model attribute (#72078)

This patch adds a per-global code model attribute, which can override
the target's code model to access global variables.

Currently, the code model attribute is only supported on LoongArch. This
patch also maps GCC's code model names to LLVM's, which allows for
better compatibility between the two compilers.

Suggested-by: Arthur Eubanks <aeubanks at google.com>
Link:
https://discourse.llvm.org/t/how-to-best-implement-code-model-overriding-for-certain-values/71816
Link:
https://discourse.llvm.org/t/rfc-add-per-global-code-model-attribute/74944

---------

Signed-off-by: WANG Rui <wangrui at loongson.cn>

  Commit: 2652243f19314cf0a7583402d37d28dbae9ec1e6
      https://github.com/llvm/llvm-project/commit/2652243f19314cf0a7583402d37d28dbae9ec1e6
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_common.h
    M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_report.cpp
    M compiler-rt/lib/tsan/rtl/tsan_report.cpp

  Log Message:
  -----------
  [NFC][tsan] Move SkipInternalFrames into sanitizer_common (#77146)

  Commit: 8424274a4958e4aff546de13049fbb3476e34e70
      https://github.com/llvm/llvm-project/commit/8424274a4958e4aff546de13049fbb3476e34e70
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M bolt/lib/Rewrite/JITLinkLinker.cpp
    A clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.cpp
    A clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.h
    M clang-tools-extra/clang-tidy/readability/CMakeLists.txt
    M clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/docs/clang-tidy/checks/list.rst
    A clang-tools-extra/docs/clang-tidy/checks/readability/avoid-return-with-void-value.rst
    A clang-tools-extra/test/clang-tidy/checkers/readability/avoid-return-with-void-value.cpp
    M clang/include/clang/AST/Attr.h
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/AttrDocs.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/Sema/SemaDeclAttr.cpp
    A clang/test/CodeGen/LoongArch/attributes.cpp
    A clang/test/Sema/attr-model.cpp
    M libcxx/include/__algorithm/pop_heap.h
    M libcxx/include/__algorithm/sift_down.h
    M libcxx/include/__algorithm/sort.h
    M libcxx/include/__charconv/to_chars_base_10.h
    M libcxx/include/__charconv/to_chars_integral.h
    M libcxx/include/__charconv/traits.h
    M libcxx/include/__chrono/parser_std_format_spec.h
    M libcxx/include/__config
    M libcxx/include/__filesystem/directory_iterator.h
    M libcxx/include/__filesystem/path_iterator.h
    M libcxx/include/__format/buffer.h
    M libcxx/include/__format/format_arg.h
    M libcxx/include/__format/formatter_bool.h
    M libcxx/include/__format/formatter_floating_point.h
    M libcxx/include/__format/formatter_integral.h
    M libcxx/include/__format/formatter_output.h
    M libcxx/include/__format/formatter_string.h
    M libcxx/include/__format/parser_std_format_spec.h
    M libcxx/include/__format/range_formatter.h
    M libcxx/include/__format/unicode.h
    M libcxx/include/__format/write_escaped.h
    M libcxx/include/__hash_table
    M libcxx/include/__iterator/advance.h
    M libcxx/include/__iterator/next.h
    M libcxx/include/__iterator/prev.h
    M libcxx/include/__random/negative_binomial_distribution.h
    M libcxx/include/__ranges/chunk_by_view.h
    M libcxx/include/__ranges/drop_while_view.h
    M libcxx/include/__ranges/filter_view.h
    M libcxx/include/__thread/thread.h
    M libcxx/include/__utility/exception_guard.h
    M libcxx/include/__utility/unreachable.h
    M libcxx/include/print
    M libcxx/include/regex
    M libcxx/include/set
    M libcxx/src/filesystem/error.h
    M libcxx/src/filesystem/format_string.h
    M libcxx/src/filesystem/posix_compat.h
    M libcxx/src/include/to_chars_floating_point.h
    M libcxx/src/memory_resource.cpp
    M libcxx/src/strstream.cpp
    M libcxx/src/system_error.cpp
    M libcxx/test/libcxx/utilities/assert.exception_guard.no_exceptions.pass.cpp
    M libcxx/test/std/utilities/utility/utility.unreachable/assert.unreachable.pass.cpp
    M llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
    M llvm/include/llvm/ExecutionEngine/Orc/Core.h
    M llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
    M llvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h
    M llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
    M llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp
    M llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
    M llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp
    M llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
    M llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
    M llvm/test/CodeGen/Generic/machine-function-splitter.ll
    M llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
    M llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/readability/BUILD.gn
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
    M mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
    M mlir/test/Dialect/SPIRV/IR/structure-ops.mlir
    M mlir/test/Target/SPIRV/global-variable.mlir

  Log Message:
  -----------
  [𝘀𝗽𝗿] changes introduced through rebase

Created using spr 1.3.4

[skip ci]

  Commit: 0f84fc5c5f125fde1996382be4494331f2859d69
      https://github.com/llvm/llvm-project/commit/0f84fc5c5f125fde1996382be4494331f2859d69
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M bolt/lib/Rewrite/JITLinkLinker.cpp
    A clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.cpp
    A clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.h
    M clang-tools-extra/clang-tidy/readability/CMakeLists.txt
    M clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/docs/clang-tidy/checks/list.rst
    A clang-tools-extra/docs/clang-tidy/checks/readability/avoid-return-with-void-value.rst
    A clang-tools-extra/test/clang-tidy/checkers/readability/avoid-return-with-void-value.cpp
    M clang/include/clang/AST/Attr.h
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/AttrDocs.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/Sema/SemaDeclAttr.cpp
    A clang/test/CodeGen/LoongArch/attributes.cpp
    A clang/test/Sema/attr-model.cpp
    M libcxx/include/__algorithm/pop_heap.h
    M libcxx/include/__algorithm/sift_down.h
    M libcxx/include/__algorithm/sort.h
    M libcxx/include/__charconv/to_chars_base_10.h
    M libcxx/include/__charconv/to_chars_integral.h
    M libcxx/include/__charconv/traits.h
    M libcxx/include/__chrono/parser_std_format_spec.h
    M libcxx/include/__config
    M libcxx/include/__filesystem/directory_iterator.h
    M libcxx/include/__filesystem/path_iterator.h
    M libcxx/include/__format/buffer.h
    M libcxx/include/__format/format_arg.h
    M libcxx/include/__format/formatter_bool.h
    M libcxx/include/__format/formatter_floating_point.h
    M libcxx/include/__format/formatter_integral.h
    M libcxx/include/__format/formatter_output.h
    M libcxx/include/__format/formatter_string.h
    M libcxx/include/__format/parser_std_format_spec.h
    M libcxx/include/__format/range_formatter.h
    M libcxx/include/__format/unicode.h
    M libcxx/include/__format/write_escaped.h
    M libcxx/include/__hash_table
    M libcxx/include/__iterator/advance.h
    M libcxx/include/__iterator/next.h
    M libcxx/include/__iterator/prev.h
    M libcxx/include/__random/negative_binomial_distribution.h
    M libcxx/include/__ranges/chunk_by_view.h
    M libcxx/include/__ranges/drop_while_view.h
    M libcxx/include/__ranges/filter_view.h
    M libcxx/include/__thread/thread.h
    M libcxx/include/__utility/exception_guard.h
    M libcxx/include/__utility/unreachable.h
    M libcxx/include/print
    M libcxx/include/regex
    M libcxx/include/set
    M libcxx/src/filesystem/error.h
    M libcxx/src/filesystem/format_string.h
    M libcxx/src/filesystem/posix_compat.h
    M libcxx/src/include/to_chars_floating_point.h
    M libcxx/src/memory_resource.cpp
    M libcxx/src/strstream.cpp
    M libcxx/src/system_error.cpp
    M libcxx/test/libcxx/utilities/assert.exception_guard.no_exceptions.pass.cpp
    M libcxx/test/std/utilities/utility/utility.unreachable/assert.unreachable.pass.cpp
    M llvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
    M llvm/include/llvm/ExecutionEngine/Orc/Core.h
    M llvm/include/llvm/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.h
    M llvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h
    M llvm/lib/ExecutionEngine/JITLink/JITLink.cpp
    M llvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp
    M llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
    M llvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp
    M llvm/lib/ExecutionEngine/Orc/MachOPlatform.cpp
    M llvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
    M llvm/test/CodeGen/Generic/machine-function-splitter.ll
    M llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
    M llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/readability/BUILD.gn
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    M mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp
    M mlir/lib/Target/SPIRV/Serialization/SerializeOps.cpp
    M mlir/test/Dialect/SPIRV/IR/structure-ops.mlir
    M mlir/test/Target/SPIRV/global-variable.mlir

  Log Message:
  -----------
  rebase

Created using spr 1.3.4

Compare: https://github.com/llvm/llvm-project/compare/7909ccf2eb55...0f84fc5c5f12