[all-commits] [llvm/llvm-project] 10b03e: [RemoveDIs] Handle DPValues in FastISel (#76952)

[Orlando Cazalet-Hyams via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 10b03e66629aedad79a804e22d23b575077303b3
      https://github.com/llvm/llvm-project/commit/10b03e66629aedad79a804e22d23b575077303b3
  Author: Orlando Cazalet-Hyams <orlando.hyams at sony.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M llvm/include/llvm/CodeGen/FastISel.h
    M llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
    M llvm/test/CodeGen/AArch64/fast-isel-branch-uncond-debug.ll
    M llvm/test/CodeGen/AArch64/fast-isel-dbg.ll
    M llvm/test/CodeGen/AArch64/fastisel-debugvalue-undef.ll
    M llvm/test/CodeGen/ARM/debug-info-blocks.ll
    M llvm/test/CodeGen/Generic/csw-debug-assert.ll
    M llvm/test/CodeGen/X86/2010-08-04-StackVariable.ll
    M llvm/test/CodeGen/X86/DbgValueOtherTargets.test
    M llvm/test/CodeGen/X86/fast-isel-dbg-value-alloca.ll
    M llvm/test/CodeGen/X86/fold-sext-trunc.ll
    M llvm/test/CodeGen/X86/fold-zext-trunc.ll
    M llvm/test/CodeGen/X86/label-heapallocsite.ll
    M llvm/test/CodeGen/X86/machine-outliner-disubprogram.ll
    M llvm/test/CodeGen/X86/pr53243-tail-call-fastisel.ll
    M llvm/test/CodeGen/X86/sink-local-value.ll
    M llvm/test/DebugInfo/AArch64/cfi-eof-prologue.ll
    M llvm/test/DebugInfo/AArch64/frameindices.ll
    M llvm/test/DebugInfo/ARM/split-complex.ll
    M llvm/test/DebugInfo/COFF/class-options-common.ll
    M llvm/test/DebugInfo/COFF/cpp-mangling.ll
    M llvm/test/DebugInfo/COFF/enum-co.ll
    M llvm/test/DebugInfo/COFF/function-options.ll
    M llvm/test/DebugInfo/COFF/global_visibility.ll
    M llvm/test/DebugInfo/COFF/globals.ll
    M llvm/test/DebugInfo/COFF/lambda.ll
    M llvm/test/DebugInfo/COFF/lines-bb-start.ll
    M llvm/test/DebugInfo/COFF/nrvo.ll
    M llvm/test/DebugInfo/COFF/numeric-leaves.ll
    M llvm/test/DebugInfo/COFF/parent-type-scopes.ll
    M llvm/test/DebugInfo/COFF/purge-typedef-udts.ll
    M llvm/test/DebugInfo/COFF/thunk.ll
    M llvm/test/DebugInfo/COFF/type-quals.ll
    M llvm/test/DebugInfo/COFF/types-cvarargs.ll
    M llvm/test/DebugInfo/COFF/types-integer-old.ll
    M llvm/test/DebugInfo/COFF/types-method-ref-qualifiers.ll
    M llvm/test/DebugInfo/Generic/2010-10-01-crash.ll
    M llvm/test/DebugInfo/Generic/PR20038.ll
    M llvm/test/DebugInfo/Generic/dead-argument-order.ll
    M llvm/test/DebugInfo/Generic/discriminated-union.ll
    M llvm/test/DebugInfo/Generic/disubrange_vla.ll
    M llvm/test/DebugInfo/Generic/enum-types.ll
    M llvm/test/DebugInfo/Generic/enum.ll
    M llvm/test/DebugInfo/Generic/import-inlined-declaration.ll
    M llvm/test/DebugInfo/Generic/inlined-vars.ll
    M llvm/test/DebugInfo/Generic/recursive_inlining.ll
    M llvm/test/DebugInfo/Generic/univariant-discriminated-union.ll
    M llvm/test/DebugInfo/Mips/delay-slot.ll
    M llvm/test/DebugInfo/X86/aligned_stack_var.ll
    M llvm/test/DebugInfo/X86/arguments.ll
    M llvm/test/DebugInfo/X86/asan_debug_info.ll
    M llvm/test/DebugInfo/X86/byvalstruct.ll
    M llvm/test/DebugInfo/X86/convert-linked.ll
    M llvm/test/DebugInfo/X86/dbg-declare-arg.ll
    M llvm/test/DebugInfo/X86/dbg-declare-inalloca.ll
    M llvm/test/DebugInfo/X86/dbg-declare.ll
    M llvm/test/DebugInfo/X86/dbg_value_direct.ll
    M llvm/test/DebugInfo/X86/debug-info-template-parameter.ll
    M llvm/test/DebugInfo/X86/debug_value_list_selectiondag.ll
    M llvm/test/DebugInfo/X86/double-declare.ll
    M llvm/test/DebugInfo/X86/fi-piece.ll
    M llvm/test/DebugInfo/X86/implicit_value-double.ll
    M llvm/test/DebugInfo/X86/instr-ref-opt-levels.ll
    M llvm/test/DebugInfo/X86/instr-ref-selectiondag.ll
    M llvm/test/DebugInfo/X86/missing-abstract-variable.ll
    M llvm/test/DebugInfo/X86/parameters.ll
    M llvm/test/DebugInfo/X86/pieces-1.ll
    M llvm/test/DebugInfo/X86/reference-argument.ll
    M llvm/test/DebugInfo/X86/spill-indirect-nrvo.ll
    M llvm/test/DebugInfo/X86/sret.ll
    M llvm/test/DebugInfo/X86/subreg.ll
    M llvm/test/DebugInfo/X86/subregisters.ll
    M llvm/test/DebugInfo/X86/vla.ll

  Log Message:
  -----------
  [RemoveDIs] Handle DPValues in FastISel (#76952)

The change is fairly mechanical:
1. Factor code from `FastISel::selectIntrinsicCall`, which converts
debug intrinsics into debug instructions, into functions (NFC).
2. Call those functions for DPValues attached to instructions too.

The test updates look the same as other RemoveDIs changes: re-run the
tests with `--try-experimental-debuginfo-iterators`, which checks the
output is identical using the new debug info format (if it has been
enabled in the cmake configuration).

Depends on #76941 (otherwise some modified tests spuriously fail).