[all-commits] [llvm/llvm-project] 2a1e39: [llvm][lit] Handle case when there is no llvm defa...

David Spickett via All-commits all-commits at lists.llvm.org
Fri Jan 5 00:55:28 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2a1e3906a4913ebf11760edb8d51c099a9cedf41
      https://github.com/llvm/llvm-project/commit/2a1e3906a4913ebf11760edb8d51c099a9cedf41
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M llvm/utils/lit/lit/llvm/config.py

  Log Message:
  -----------
  [llvm][lit] Handle case when there is no llvm default target triple (#76934)

This can happen when you do not choose a specific target triple, and do
not enable the host architecture when building (if you do enable it, it
would become the default target). Such as only enabling RISC-V, when
building on an AArch64 machine.

Originally reported
https://discourse.llvm.org/t/llvm-test-error-could-not-turn-into-itanium-abi-triple/76013.

When attempting to run a single test via lit you get: `Could not turn ''
into Itanium ABI triple`

Setting a default triple with `LLVM_DEFAULT_TARGET_TRIPLE` works around
the issue.

This change copies the existing host triple check to target triple, and
adds a note to highlight the potential issue. As `check-clang` on my
AArch64 machine failed 32% of tests in this configuration.

Which is to be expected and is ok if you only want to run specific
tests, but for anyone unintentionally building this way the note is a
clue to the cause.




More information about the All-commits mailing list