[all-commits] [llvm/llvm-project] 2336f7: [clangd] Dont require confirmation for include-cle...

[kadir çetinkaya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2336f792bc5a1d9195c1bd995b6040c13e73d4e7
      https://github.com/llvm/llvm-project/commit/2336f792bc5a1d9195c1bd995b6040c13e73d4e7
  Author: kadir çetinkaya <kadircet at google.com>
  Date:   2024-01-04 (Thu, 04 Jan 2024)

  Changed paths:
    M clang-tools-extra/clangd/IncludeCleaner.cpp
    M clang-tools-extra/clangd/test/include-cleaner-batch-fix.test

  Log Message:
  -----------
  [clangd] Dont require confirmation for include-cleaner batch-fixes (#76826)

False negative/positive rate has decreased to the degree that these
extra confirmations no longer provide any value, but only create
friction in the happy case.

When we have false analysis, people usually need to apply the fixes and
run the builds to discover the failure. At that point they can add
relevant IWYU pragmas to guide analysis, and will be more likely to
create bug reports due to extra annoyance :)