[all-commits] [llvm/llvm-project] 985bb3: [mlir] fix bytecode writer after c1eab57673ef3eb28

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 985bb3a20a788b3cda3256084fbdef20296ba8cb
      https://github.com/llvm/llvm-project/commit/985bb3a20a788b3cda3256084fbdef20296ba8cb
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2024-01-04 (Thu, 04 Jan 2024)

  Changed paths:
    M mlir/lib/Bytecode/Writer/BytecodeWriter.cpp
    M mlir/lib/Bytecode/Writer/IRNumbering.cpp
    M mlir/unittests/Bytecode/BytecodeTest.cpp

  Log Message:
  -----------
  [mlir] fix bytecode writer after c1eab57673ef3eb28

The change in c1eab57 fixed the
behavior of `getDiscardableAttrDictionary` for ops that are not using
properties to only return discardable attributes. Bytecode writer was
relying on the wrong behavior and would assume all attributes are
discardable, without appropriate testing. Fix that and add a test.


  Commit: 5ed11e767c0c39a3bc8e035588e7a383849d46a8
      https://github.com/llvm/llvm-project/commit/5ed11e767c0c39a3bc8e035588e7a383849d46a8
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2024-01-04 (Thu, 04 Jan 2024)

  Changed paths:
    M mlir/lib/Bytecode/Writer/IRNumbering.cpp

  Log Message:
  -----------
  [mlir] don't use magic numbers in IRNumbering.cpp

Bytecode versions have named constants that should be used instead of
magic numbers.


Compare: https://github.com/llvm/llvm-project/compare/26993f61673e...5ed11e767c0c