[all-commits] [llvm/llvm-project] ffd173: [lldb-dap] Emit more structured info along with va...

[Walter Erquinigo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ffd173ba0b4a6d84f45308e78cea4af611bec10e
      https://github.com/llvm/llvm-project/commit/ffd173ba0b4a6d84f45308e78cea4af611bec10e
  Author: Walter Erquinigo <a20012251 at gmail.com>
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/optimized/TestDAP_optimized.py
    M lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py
    M lldb/tools/lldb-dap/BreakpointBase.cpp
    M lldb/tools/lldb-dap/JSONUtils.cpp
    M lldb/tools/lldb-dap/JSONUtils.h
    M lldb/tools/lldb-dap/lldb-dap.cpp

  Log Message:
  -----------
  [lldb-dap] Emit more structured info along with variables (#75244)

In order to allow smarter vscode extensions, it's useful to send
additional structured information of SBValues to the client.
Specifically, I'm now sending error, summary, autoSummary and
inMemoryValue in addition to the existing properties being sent. This is
cheap because these properties have to be calculated anyway to generate
the display value of the variable, but they are now available for
extensions to better analyze variables. For example, if the error field
is not present, the extension might be able to provide cool features,
and the current way to do that is to look for the `"<error: "` prefix,
which is error-prone.

This also incorporates a tiny feedback from
https://github.com/llvm/llvm-project/pull/74865#issuecomment-1850695477