[all-commits] [llvm/llvm-project] fa8347: [Clang][RISCV] bfloat uses 'y' instead of 'b' (#76...

Michael Maitland via All-commits all-commits at lists.llvm.org
Sat Dec 30 08:31:39 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fa8347fbc602d78a7e4297aa83a686b62943d828
      https://github.com/llvm/llvm-project/commit/fa8347fbc602d78a7e4297aa83a686b62943d828
  Author: Michael Maitland <michaeltmaitland at gmail.com>
  Date:   2023-12-30 (Sat, 30 Dec 2023)

  Changed paths:
    M clang/include/clang/Basic/riscv_sifive_vector.td
    M clang/include/clang/Basic/riscv_vector_common.td
    M clang/lib/Support/RISCVVIntrinsicUtils.cpp
    M clang/utils/TableGen/RISCVVEmitter.cpp

  Log Message:
  -----------
  [Clang][RISCV] bfloat uses 'y' instead of 'b' (#76575)

Builtins.def says that bfloat should be represented by the 'y'
character, not the 'b' character. The 'b' character is specified to
represent boolean. The implementation currently uses 'b' correctly for
boolean and incorrectly re-uses 'b' for bfloat.

This was not caught since no builtins are emitted in
build/tools/clang/include/clang/Basic/riscv_sifive_vector_builtins.inc.
Don't know that we can test this without creating builtins that expose
this issue, although I'm not sure we really want to do that.




More information about the All-commits mailing list