[all-commits] [llvm/llvm-project] 64f068: [Libomptarget] Rework image checking further (#76120)

Joseph Huber via All-commits all-commits at lists.llvm.org
Fri Dec 29 13:14:53 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 64f0681e97c6046912dc0d80bc56709f72045338
      https://github.com/llvm/llvm-project/commit/64f0681e97c6046912dc0d80bc56709f72045338
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2023-12-29 (Fri, 29 Dec 2023)

  Changed paths:
    M openmp/libomptarget/plugins-nextgen/common/include/JIT.h
    M openmp/libomptarget/plugins-nextgen/common/include/PluginInterface.h
    M openmp/libomptarget/plugins-nextgen/common/src/JIT.cpp
    M openmp/libomptarget/plugins-nextgen/common/src/PluginInterface.cpp
    M openmp/libomptarget/plugins-nextgen/common/src/Utils/ELF.cpp

  Log Message:
  -----------
  [Libomptarget] Rework image checking further (#76120)

Summary:
In the future, we may have more checks for different kinds of inputs,
e.g. SPIR-V. This patch simply reworks the handling to be more generic
and do the magic detection up-front. The checks inside the routines are
now asserts so we don't spend time checking this stuff over and over
again.

This patch also tweaked the bitcode check. I used a different function
to get the Lazy-IR module now, as it returns the raw expected value
rather than the SM diganostic.

No functionality change intended.




More information about the All-commits mailing list