[all-commits] [llvm/llvm-project] f9e239: [X86][NFC] Remove class ADCOXOp(RR|RM) and redunda...

Shengchen Kan via All-commits all-commits at lists.llvm.org
Mon Dec 25 20:56:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f9e23991a7bb99eca338c4c3aae842386ae5190f
      https://github.com/llvm/llvm-project/commit/f9e23991a7bb99eca338c4c3aae842386ae5190f
  Author: Shengchen Kan <shengchen.kan at intel.com>
  Date:   2023-12-26 (Tue, 26 Dec 2023)

  Changed paths:
    M llvm/lib/Target/X86/X86InstrArithmetic.td
    M llvm/lib/Target/X86/X86InstrPredicates.td

  Log Message:
  -----------
  [X86][NFC] Remove class ADCOXOp(RR|RM) and redundant let statements

1. Remove these two classes b/c opcode is changed from 0xF6 to 0x66
   after promotion, then the classes become useless.
2. Remove `OpSize = OpSizeFixed` b/c the default value is OpSizeFixed.
3. Remove `let isCommutable = 1` b/c ADCX/ADOX is not VEX-encoding,
   we can not apply VEX3ToVEX2 optimization for it and the compiler
   never emits it.
4. Remove predicate `HasADX` due to no pattern

This patch is to extract the NFC in #76319 into a separate commit.




More information about the All-commits mailing list