[all-commits] [llvm/llvm-project] b203d5: [libc++] Optimize std::find if types are integral ...

Sat Dec 23 09:38:45 PST 2023

  Branch: refs/heads/users/vitalybuka/spr/sanitizers-optimize-locking-stackdepotbase-for-fork
  Home:   https://github.com/llvm/llvm-project
  Commit: b203d5320df7754bf0ce019f01347a0ef743a207
      https://github.com/llvm/llvm-project/commit/b203d5320df7754bf0ce019f01347a0ef743a207
  Author: Nikolas Klauser <nikolasklauser at berlin.de>
  Date:   2023-12-23 (Sat, 23 Dec 2023)

  Changed paths:
    M libcxx/include/__algorithm/find.h
    M libcxx/test/std/algorithms/alg.nonmodifying/alg.find/find.pass.cpp

  Log Message:
  -----------
  [libc++] Optimize std::find if types are integral and have the same signedness (#70345)

Fixes #70238

  Commit: 5841140e38c94f3d2b29354f67e70803d88ce174
      https://github.com/llvm/llvm-project/commit/5841140e38c94f3d2b29354f67e70803d88ce174
  Author: Mark de Wever <koraq at xs4all.nl>
  Date:   2023-12-23 (Sat, 23 Dec 2023)

  Changed paths:
    M libcxx/modules/std/algorithm.inc

  Log Message:
  -----------
  [libc++][modules] Fixes C++20 build errors.

Recent CI changes have disabled testing modules in different
configurations. This broke building the std and std.compat module in
C++20. This was found by the CI in #76246.

  Commit: ed6dc6286264f0b6e94bb786a462d9975144ee7d
      https://github.com/llvm/llvm-project/commit/ed6dc6286264f0b6e94bb786a462d9975144ee7d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-12-23 (Sat, 23 Dec 2023)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

  Log Message:
  -----------
  DAG: Handle equal size element build_vector promotion (#76213)

  Commit: fbcf8a8cbb2461730bfd0603b396842925a88ef2
      https://github.com/llvm/llvm-project/commit/fbcf8a8cbb2461730bfd0603b396842925a88ef2
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2023-12-23 (Sat, 23 Dec 2023)

  Changed paths:
    M llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
    M llvm/test/Transforms/ConstraintElimination/add-nuw.ll
    M llvm/test/Transforms/ConstraintElimination/and-implied-by-operands.ll
    M llvm/test/Transforms/ConstraintElimination/gep-arithmetic-add.ll
    M llvm/test/Transforms/ConstraintElimination/gep-arithmetic.ll
    M llvm/test/Transforms/ConstraintElimination/geps-pointers-to-structs.ll
    M llvm/test/Transforms/ConstraintElimination/large-constant-ints.ll
    M llvm/test/Transforms/ConstraintElimination/loops-bottom-tested-pointer-cmps.ll
    M llvm/test/Transforms/ConstraintElimination/loops-header-tested-base.ll
    M llvm/test/Transforms/ConstraintElimination/loops-header-tested-pointer-cmps.ll
    M llvm/test/Transforms/ConstraintElimination/max-row-limit.ll
    M llvm/test/Transforms/ConstraintElimination/mul.ll
    M llvm/test/Transforms/ConstraintElimination/or-implied-by-operands.ll
    M llvm/test/Transforms/ConstraintElimination/or.ll
    M llvm/test/Transforms/ConstraintElimination/reason-about-add-operands.ll
    M llvm/test/Transforms/ConstraintElimination/reproducer-remarks-debug.ll
    M llvm/test/Transforms/ConstraintElimination/reproducer-remarks.ll
    M llvm/test/Transforms/ConstraintElimination/shl.ll
    M llvm/test/Transforms/ConstraintElimination/sub-nuw.ll
    M llvm/test/Transforms/PhaseOrdering/runtime-check-removal.ll

  Log Message:
  -----------
  [ConstraintElim] Add (UGE, var, 0) to unsigned system for new vars. (#76262)

The constraint system used for ConstraintElimination assumes all
varibles to be signed. This can cause missed optimization in the
unsigned system, due to missing the information that all variables are
unsigned (non-negative).

Variables can be marked as non-negative by adding Var >= 0 for all
variables. This is done for arguments on ConstraintInfo construction and
after adding new variables. This handles cases like the ones outlined in
https://discourse.llvm.org/t/why-does-llvm-not-perform-range-analysis-on-integer-values/74341

The original example shared above is now handled without this change,
but adding another variable means that instcombine won't be able to
simplify examples like https://godbolt.org/z/hTnra7zdY

Adding the extra variables comes with a slight compile-time increase
https://llvm-compile-time-tracker.com/compare.php?from=7568b36a2bc1a1e496ec29246966ffdfc3a8b87f&to=641a47f0acce7755e340447386013a2e086f03d9&stat=instructions:u

stage1-O3    stage1-ReleaseThinLTO    stage1-ReleaseLTO-g  stage1-O0-g
 +0.04%           +0.07%                   +0.05%           +0.02%
stage2-O3    stage2-O0-g    stage2-clang
  +0.05%         +0.05%        +0.05%

https://github.com/llvm/llvm-project/pull/76262

  Commit: acacec3bbf4586ef9bc6c4f31707d3515d5215a1
      https://github.com/llvm/llvm-project/commit/acacec3bbf4586ef9bc6c4f31707d3515d5215a1
  Author: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
  Date:   2023-12-23 (Sat, 23 Dec 2023)

  Changed paths:
    M llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
    M llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
    M llvm/unittests/CodeGen/InstrRefLDVTest.cpp

  Log Message:
  -----------
  [LiveDebugValues][nfc] Reduce memory usage of InstrRef (#76051)

Commit 1b531d54f623 (#74203) removed the usage of unique_ptrs of arrays
in favour of using vectors, but inadvertently increased peak memory
usage by removing the ability to deallocate vector memory that was no
longer needed mid-LDV.

In that same review, it was pointed out that `FuncValueTable` typedef
could be removed, since it was "just a vector".

This commit addresses both issues by making `FuncValueTable` a real data
structure, capable of mapping BBs to ValueTables and able to free
ValueTables as needed.

This reduces peak memory usage in the compiler by 10% in the benchmarks
flagged by the original review.

As a consequence, we had to remove a handful of instances of the
"declare-then-initialize" antipattern in unittests, as the
FuncValueTable class is no longer default-constructible.

  Commit: 7247f809869356f9ead1434c0a5a9415479b550c
      https://github.com/llvm/llvm-project/commit/7247f809869356f9ead1434c0a5a9415479b550c
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2023-12-23 (Sat, 23 Dec 2023)

  Changed paths:
    M libcxx/include/__algorithm/find.h
    M libcxx/modules/std/algorithm.inc
    M libcxx/test/std/algorithms/alg.nonmodifying/alg.find/find.pass.cpp
    M llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
    M llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.h
    M llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
    M llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
    M llvm/test/Transforms/ConstraintElimination/add-nuw.ll
    M llvm/test/Transforms/ConstraintElimination/and-implied-by-operands.ll
    M llvm/test/Transforms/ConstraintElimination/gep-arithmetic-add.ll
    M llvm/test/Transforms/ConstraintElimination/gep-arithmetic.ll
    M llvm/test/Transforms/ConstraintElimination/geps-pointers-to-structs.ll
    M llvm/test/Transforms/ConstraintElimination/large-constant-ints.ll
    M llvm/test/Transforms/ConstraintElimination/loops-bottom-tested-pointer-cmps.ll
    M llvm/test/Transforms/ConstraintElimination/loops-header-tested-base.ll
    M llvm/test/Transforms/ConstraintElimination/loops-header-tested-pointer-cmps.ll
    M llvm/test/Transforms/ConstraintElimination/max-row-limit.ll
    M llvm/test/Transforms/ConstraintElimination/mul.ll
    M llvm/test/Transforms/ConstraintElimination/or-implied-by-operands.ll
    M llvm/test/Transforms/ConstraintElimination/or.ll
    M llvm/test/Transforms/ConstraintElimination/reason-about-add-operands.ll
    M llvm/test/Transforms/ConstraintElimination/reproducer-remarks-debug.ll
    M llvm/test/Transforms/ConstraintElimination/reproducer-remarks.ll
    M llvm/test/Transforms/ConstraintElimination/shl.ll
    M llvm/test/Transforms/ConstraintElimination/sub-nuw.ll
    M llvm/test/Transforms/PhaseOrdering/runtime-check-removal.ll
    M llvm/unittests/CodeGen/InstrRefLDVTest.cpp

  Log Message:
  -----------
  rebase

Created using spr 1.3.4

Compare: https://github.com/llvm/llvm-project/compare/05584dc62fad...7247f8098693