[all-commits] [llvm/llvm-project] 63c314: [llvm-exegesis] Fix stack pointer register restora...

Aiden Grossman via All-commits all-commits at lists.llvm.org
Fri Dec 22 17:58:39 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 63c314835458211b165e48b2278800ea6d52620a
      https://github.com/llvm/llvm-project/commit/63c314835458211b165e48b2278800ea6d52620a
  Author: Aiden Grossman <agrossman154 at yahoo.com>
  Date:   2023-12-22 (Fri, 22 Dec 2023)

  Changed paths:
    M llvm/test/tools/llvm-exegesis/X86/latency/subprocess-preserved-registers.s
    M llvm/tools/llvm-exegesis/lib/Assembler.cpp

  Log Message:
  -----------
  [llvm-exegesis] Fix stack pointer register restoration

9eb80ab3787e1851be8c686651688e870b93506b changed the method for stack
pointer restoration to fix segmentation faults. However, I made a
mistake in the patch and swapped a != for a ==, which caused an
arbitrary register (the first one specified) to get restored rather than
the stack pointer specifically. This patch fixes that issue and adds
test coverage to prevent regression.




More information about the All-commits mailing list