[all-commits] [llvm/llvm-project] d03beb: [clang-format] Do not break on JS fields like on g...

Ilya Biryukov via All-commits all-commits at lists.llvm.org
Fri Dec 22 05:41:52 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d03beb94195ae6889d3075dabe64d58c9ab5d1d2
      https://github.com/llvm/llvm-project/commit/d03beb94195ae6889d3075dabe64d58c9ab5d1d2
  Author: Ilya Biryukov <ibiryukov at google.com>
  Date:   2023-12-22 (Fri, 22 Dec 2023)

  Changed paths:
    M clang/lib/Format/UnwrappedLineParser.cpp
    M clang/unittests/Format/FormatTestJS.cpp

  Log Message:
  -----------
  [clang-format] Do not break on JS fields like on goto labels (#76233)

This regressions was introduced in
70d7ea0cebcf363cd0ddcfb76375fb5fada87dd5.
The commit moved some code and correctly picked up an explicit check for
not running on Verilog.
However, the moved code also never ran for JavaScript and after the
commit we run it there and
this causes the wrong formatting of:

```js
export type Params = Config&{
  columns: Column[];
};
```
into
```js
export type Params = Config&{
columns:
  Column[];
};
```




More information about the All-commits mailing list