[all-commits] [llvm/llvm-project] 12250c: Reland [OpenMP][Fix] libomptarget Fortran tests (#...

Fabian Mora via All-commits all-commits at lists.llvm.org
Thu Dec 21 14:18:50 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 12250c4092b9f8fd043b37cbb73555706a4a412b
      https://github.com/llvm/llvm-project/commit/12250c4092b9f8fd043b37cbb73555706a4a412b
  Author: Fabian Mora <fmora.dev at gmail.com>
  Date:   2023-12-21 (Thu, 21 Dec 2023)

  Changed paths:
    M openmp/libomptarget/test/lit.cfg
    M openmp/libomptarget/test/offloading/fortran/basic-target-region-1D-array-section.f90
    M openmp/libomptarget/test/offloading/fortran/basic-target-region-3D-array-section.f90
    M openmp/libomptarget/test/offloading/fortran/basic-target-region-3D-array.f90
    M openmp/libomptarget/test/offloading/fortran/basic_target_region.f90
    M openmp/libomptarget/test/offloading/fortran/constant-arr-index.f90
    M openmp/libomptarget/test/offloading/fortran/declare-target-array-in-target-region.f90
    M openmp/libomptarget/test/offloading/fortran/double-target-call-with-declare-target.f90
    M openmp/libomptarget/test/offloading/fortran/target-region-implicit-array.f90
    M openmp/libomptarget/test/offloading/fortran/target_map_common_block.f90
    M openmp/libomptarget/test/offloading/fortran/target_map_common_block2.f90

  Log Message:
  -----------
  Reland [OpenMP][Fix] libomptarget Fortran tests (#76189)

This patch fixes the erroneous multiple-target requirement in Fortran
offloading tests. Additionally, it adds two new variables
(test_flags_clang, test_flags_flang) to lit.cfg so that
compiler-specific flags for Clang and Flang can be specified.

This patch re-lands: #74543. The error was caused by having:
```
config.substitutions.append(("%flags", config.test_flags))
config.substitutions.append(("%flags_clang", config.test_flags_clang))
config.substitutions.append(("%flags_flang", config.test_flags_flang))
```
when instead it has to be:
```
config.substitutions.append(("%flags_clang", config.test_flags_clang))
config.substitutions.append(("%flags_flang", config.test_flags_flang))
config.substitutions.append(("%flags", config.test_flags))
```
because LIT replaces with the first longest sub-string match.




More information about the All-commits mailing list