[all-commits] [llvm/llvm-project] 2fe94c: [X86][NFC] Refine code in X86InstrArithmetic.td

Shengchen Kan via All-commits all-commits at lists.llvm.org
Thu Dec 21 06:25:53 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2fe94cead0a55d8d269e6e32bb95f7aa987d4db8
      https://github.com/llvm/llvm-project/commit/2fe94cead0a55d8d269e6e32bb95f7aa987d4db8
  Author: Shengchen Kan <shengchen.kan at intel.com>
  Date:   2023-12-21 (Thu, 21 Dec 2023)

  Changed paths:
    M llvm/lib/Target/X86/X86InstrArithmetic.td
    M llvm/lib/Target/X86/X86InstrUtils.td

  Log Message:
  -----------
  [X86][NFC] Refine code in X86InstrArithmetic.td

1. Simplify the variable name
2. Change HasOddOpcode to HasEvenOpcode b/c
  a. opcode of any 8-bit arithmetic instruction is even
  b. opcode of a 16/32/64-bit arithmetic instruction is usually
     odd, but it can be even sometimes, e.g. INC/DEC, ADCX/ADOX
  c. so that we can remove `let Opcode = o` for the mentioned corner
     cases.




More information about the All-commits mailing list