[all-commits] [llvm/llvm-project] 17afa5: [mlir][nfc] Update tests for Contract -> Op transf...

[Andrzej Warzyński via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 17afa5befb4cbe86c22c25ae1603433c8bd21551
      https://github.com/llvm/llvm-project/commit/17afa5befb4cbe86c22c25ae1603433c8bd21551
  Author: Andrzej Warzyński <andrzej.warzynski at arm.com>
  Date:   2023-12-21 (Thu, 21 Dec 2023)

  Changed paths:
    A mlir/test/Dialect/Vector/vector-contract-to-outerproduct-matmul-transforms.mlir
    M mlir/test/Dialect/Vector/vector-contract-to-outerproduct-matvec-transforms.mlir
    R mlir/test/Dialect/Vector/vector-contract-to-outerproduct-transforms.mlir

  Log Message:
  -----------
  [mlir][nfc] Update tests for Contract -> Op transforms (#76054)

Updates two tests for vector.contract -> vector.outerproduct
transformations:

1. Rename "vector-contract-to-outerproduct-transforms.mlir" as
   "vector-contract-to-outerproduct-matmul-transforms.mlir". The new
   name more accurate captures what's being tested. it is also
   consistent with
   "vector-contract-to-outerproduct-matvec-transforms.mlir", which
   covers vector matvec operations and makes finding relevant tests
   easier.

2. For matmul tests, move the traits definining the iteration spaces to
   the top of the file. This is consistent with how matvec tests are
   defined and also makes it easy to quickly identify what cases are
   covered.

3. For matmul tests, use more meaningful names for function arguments.
   This helps keep things consistent across the file (i.e. function
   definitions wih check lines and comments).

4. For matvec test, move a few tests around so that the most basic case
   (without masking) is first.

5. Update comments.