[all-commits] [llvm/llvm-project] 5c1a41: Revert "[clang] Add getClangVendor() and use it in...

[Dimitry Andric via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5c1a41f8ad0c02a24345efb4adc424396b7e446b
      https://github.com/llvm/llvm-project/commit/5c1a41f8ad0c02a24345efb4adc424396b7e446b
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M clang/include/clang/Basic/Version.h
    M clang/lib/Basic/Version.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp

  Log Message:
  -----------
  Revert "[clang] Add getClangVendor() and use it in CodeGenModule.cpp (#75935)"

This reverts commit 9055519103eadfba0b48810be926883a71890c55, due to an
incorrectly chosen commit message.


  Commit: 2c27013fa918211816d24c9d2530469fd822bc00
      https://github.com/llvm/llvm-project/commit/2c27013fa918211816d24c9d2530469fd822bc00
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M clang/include/clang/Basic/Version.h
    M clang/lib/Basic/Version.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp

  Log Message:
  -----------
  [clang] Add getClangVendor() and use it in CodeGenModule.cpp (#75935)

In 9a38a72f1d482 `ProductId` was assigned from the stringified value of
`CLANG_VENDOR`, if that macro was defined. However, `CLANG_VENDOR` is
supposed to be a string, as it is defined (optionally) as such in the
top-level clang `CMakeLists.txt`.

Furthermore, `CLANG_VENDOR` is only passed as a build-time define when
compiling `Version.cpp`, so add a `getClangVendor()` function to
`Version.h`, and use it in `CodegGenModule.cpp`, instead of relying on
the macro.

Fixes: 9a38a72f1d482


Compare: https://github.com/llvm/llvm-project/compare/9055519103ea...2c27013fa918