[all-commits] [llvm/llvm-project] ce2f31: [clang][CodeGen] Always use CLANG_VENDOR as a quot...

Dimitry Andric via All-commits all-commits at lists.llvm.org
Tue Dec 19 06:12:46 PST 2023


  Branch: refs/heads/users/DimitryAndric/codegen-clang-vendor
  Home:   https://github.com/llvm/llvm-project
  Commit: ce2f3105a5270a26fa3595313289dcbfa700abb9
      https://github.com/llvm/llvm-project/commit/ce2f3105a5270a26fa3595313289dcbfa700abb9
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M clang/CMakeLists.txt
    M clang/lib/Basic/CMakeLists.txt
    M clang/lib/CodeGen/CodeGenModule.cpp

  Log Message:
  -----------
  [clang][CodeGen] Always use CLANG_VENDOR as a quoted string

In 9a38a72f1d482 `ProductId` was assigned from the stringified value of
`CLANG_VENDOR`, if that macro was defined. However, `CLANG_VENDOR` is
supposed to be a string, as it is defined (optionally) as such in the
top-level clang `CMakeLists.txt`.

Move the addition of `-DCLANG_VENDOR` to the compiler flags from
`clang/lib/Basic/CMakeLists.txt` to the top-level `CMakeLists.txt`, so
it is consistent across the whole clang codebase. Then remove the
stringification from `CodeGenModule.cpp`, to make it work correctly.

Fixes:		9a38a72f1d482




More information about the All-commits mailing list