[all-commits] [llvm/llvm-project] 672f1a: [mlir][memref] Make `LoadOp::verify` error more cl...

Rik Huijzer via All-commits all-commits at lists.llvm.org
Mon Dec 18 09:41:19 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 672f1a036a28cf993e7b5b022bd5582a8924ee58
      https://github.com/llvm/llvm-project/commit/672f1a036a28cf993e7b5b022bd5582a8924ee58
  Author: Rik Huijzer <github at huijzer.xyz>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
    M mlir/test/Dialect/MemRef/invalid.mlir

  Log Message:
  -----------
  [mlir][memref] Make `LoadOp::verify` error more clear (#75831)

While debugging https://github.com/llvm/llvm-project/issues/71326, the
`LoadOp::verify` code and error were very confusing. This PR improves
that.

This code was a part from the reverted PR
https://github.com/llvm/llvm-project/pull/75519. Fixing the
`-convert-vector-to-scf` issue is going to take a bit longer and this
code was out of scope anyway.

Co-authored-by: Benjamin Maxwell <macdue at dueutil.tech>




More information about the All-commits mailing list