[all-commits] [llvm/llvm-project] 913622: [Libomptarget] Remove remaining global constructor...

Joseph Huber via All-commits all-commits at lists.llvm.org
Mon Dec 18 09:01:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 913622d012f72edb5ac3a501cef8639d0ebe471b
      https://github.com/llvm/llvm-project/commit/913622d012f72edb5ac3a501cef8639d0ebe471b
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2023-12-18 (Mon, 18 Dec 2023)

  Changed paths:
    M openmp/libomptarget/plugins-nextgen/common/src/PluginInterface.cpp

  Log Message:
  -----------
  [Libomptarget] Remove remaining global constructors in plugins (#75814)

Summary:
This patch fixes the remaining global constructor in the plguins after
addressing the ones in the JIT interface. This struct was mistakenly
using global constructors as not all the members were being initialized
properly. This was almost certainly being optimized out because it's
trivial, but would still be present in debug builds and prevented us
from compiling with `-Werror=global-constructors`. We will want to do
that once offloading is moved to a runtimes only build.




More information about the All-commits mailing list