[all-commits] [llvm/llvm-project] 41ab23: [flang] Separate definition of class FirConverter ...

[Krzysztof Parzyszek via All-commits]

  Branch: refs/heads/users/kparzysz/01-separate-fir-header
  Home:   https://github.com/llvm/llvm-project
  Commit: 41ab23798957624761db6dcc1453500a959a5f25
      https://github.com/llvm/llvm-project/commit/41ab23798957624761db6dcc1453500a959a5f25
  Author: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
  Date:   2023-12-09 (Sat, 09 Dec 2023)

  Changed paths:
    M flang/lib/Lower/Bridge.cpp
    A flang/lib/Lower/FirConverter.h

  Log Message:
  -----------
  [flang] Separate definition of class FirConverter into header file

The order of functions has been preserved, the order in the cpp file
matches the order in the header. This was meant to limit the visual
differences between the old and the new files.

Small functions and templates have their definitions in the header
(except `genFIR`).

All `genFIR` functions (except those explicitly listed as no-ops)
are defined in the cpp file.

The semantic changes are
- `FirCoverter` is defined in namespace `Fortran::lower` (was in
  anonymous namespace before).
- Helper classes `IncrementLoopInfo', `ConstructContext`, and
  `TypeInfoConverter` are now nested inside of `FirConverter` (were
  in anonymous namespace before).


  Commit: bff72ed2f163c3e791dbc562676e2293a18fd7a8
      https://github.com/llvm/llvm-project/commit/bff72ed2f163c3e791dbc562676e2293a18fd7a8
  Author: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
  Date:   2023-12-09 (Sat, 09 Dec 2023)

  Changed paths:
    M flang/lib/Lower/Bridge.cpp
    M flang/lib/Lower/FirConverter.h

  Log Message:
  -----------
  Group declarations of `genFIR` functions together, NFC

This is to make the FIR generation interface stand out visually.

The functions in the cpp file have also been reordered to match
the header.

There are no functional changes.


  Commit: a6197ad207a1e454e0395843c3df907d3fcc2290
      https://github.com/llvm/llvm-project/commit/a6197ad207a1e454e0395843c3df907d3fcc2290
  Author: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
  Date:   2023-12-09 (Sat, 09 Dec 2023)

  Changed paths:
    M flang/lib/Lower/Bridge.cpp
    M flang/lib/Lower/FirConverter.h

  Log Message:
  -----------
  Move bodies of inline functions out of class definition, NFC

This is to make the class definition more readable. There are no
functional changes.


Compare: https://github.com/llvm/llvm-project/compare/d746452e9e98...a6197ad207a1