[all-commits] [llvm/llvm-project] 1f38a0: [clang] NFCI: Remove `{File, Directory}Entry::getNa...

[Jan Svoboda via All-commits]

  Branch: refs/heads/users/jansvoboda11/get-name
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f38a04e1abad7995d3e1a200da2e14db26de16f
      https://github.com/llvm/llvm-project/commit/1f38a04e1abad7995d3e1a200da2e14db26de16f
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M clang/include/clang/Basic/DirectoryEntry.h
    M clang/include/clang/Basic/FileEntry.h
    M clang/lib/Basic/FileManager.cpp
    M clang/unittests/Basic/FileManagerTest.cpp
    M llvm/include/llvm/Support/VirtualFileSystem.h
    M llvm/lib/Support/VirtualFileSystem.cpp
    M llvm/unittests/Support/VirtualFileSystemTest.cpp

  Log Message:
  -----------
  [clang] NFCI: Remove `{File,Directory}Entry::getName()` for good


  Commit: d1eb941fb32dfd9d23a7be03b749e1bb59251285
      https://github.com/llvm/llvm-project/commit/d1eb941fb32dfd9d23a7be03b749e1bb59251285
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp
    M clang/include/clang/Basic/FileEntry.h
    M clang/include/clang/Basic/Module.h
    M clang/include/clang/Basic/SourceManager.h
    M clang/include/clang/Lex/PreprocessorLexer.h
    M clang/include/clang/Serialization/ModuleFile.h
    M clang/lib/Frontend/CompilerInstance.cpp
    M clang/lib/Lex/ModuleMap.cpp
    M clang/lib/Lex/PPDirectives.cpp
    M clang/lib/Lex/Pragma.cpp
    M clang/lib/Lex/PreprocessorLexer.cpp
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/lib/Serialization/ModuleManager.cpp
    M clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp
    M clang/tools/libclang/CXIndexDataConsumer.cpp
    M clang/tools/libclang/CXIndexDataConsumer.h
    M clang/unittests/Basic/FileEntryTest.cpp

  Log Message:
  -----------
  [clang] NFC: Remove `OptionalFileEntryRefDegradesToFileEntryPtr`


  Commit: 2c10b20bdf3e43e0abac7e8a8314b0fa9531e770
      https://github.com/llvm/llvm-project/commit/2c10b20bdf3e43e0abac7e8a8314b0fa9531e770
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp
    M clang-tools-extra/clangd/IncludeCleaner.cpp
    M clang-tools-extra/include-cleaner/lib/Analysis.cpp
    M clang/include/clang/Basic/DirectoryEntry.h
    M clang/include/clang/Basic/Module.h
    M clang/include/clang/Lex/ModuleMap.h
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  [clang] NFC: Remove 'OptionalDirectoryEntryRefDegradesToDirectoryEntryPtr'


  Commit: 934920792d74db82529404cb8beb48c1555d000d
      https://github.com/llvm/llvm-project/commit/934920792d74db82529404cb8beb48c1555d000d
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M clang/include/clang/Basic/DirectoryEntry.h
    M clang/include/clang/Basic/FileEntry.h

  Log Message:
  -----------
  [clang] NFC: "Bless" implicit conversions from `EntryRef` to `const Entry *`

The `{File,Directory}EntryRef` can be though of as a subclasses of `{File,Directory}Entry` that happen to also carry the entry name. The implicit conversions allow calling functions taking the "superclass" pointer without the awkward `&FE.getFileEntry()` dance that doesn't add any value IMO.


Compare: https://github.com/llvm/llvm-project/compare/20073d5d4efe...934920792d74