[all-commits] [llvm/llvm-project] 9eb684: [flang] Separate definition of class FirConverter ...

[Krzysztof Parzyszek via All-commits]

  Branch: refs/heads/users/kparzysz/01-separate-fir-header
  Home:   https://github.com/llvm/llvm-project
  Commit: 9eb6840a1d0d0d0ed36d6380217f348f19a90646
      https://github.com/llvm/llvm-project/commit/9eb6840a1d0d0d0ed36d6380217f348f19a90646
  Author: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M flang/lib/Lower/Bridge.cpp
    A flang/lib/Lower/FirConverter.h

  Log Message:
  -----------
  [flang] Separate definition of class FirConverter into header file

The order of functions has been preserved, the order in the cpp file
matches the order in the header. This was meant to limit the visual
differences between the old and the new files.

Small functions and templates have their definitions in the header
(except `genFIR`).

All `genFIR` functions (except those explicitly listed as no-ops)
are defined in the cpp file.

The semantic changes are
- `FirCoverter` is defined in namespace `Fortran::lower` (was in
  anonymous namespace before).
- Helper classes `IncrementLoopInfo', `ConstructContext`, and
  `TypeInfoConverter` are now nested inside of `FirConverter` (were
  in anonymous namespace before).


  Commit: 2ae85f374c2888c0aa9135761bb5f7bb95556638
      https://github.com/llvm/llvm-project/commit/2ae85f374c2888c0aa9135761bb5f7bb95556638
  Author: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M flang/lib/Lower/Bridge.cpp
    M flang/lib/Lower/FirConverter.h

  Log Message:
  -----------
  Group declarations of `genFIR` functions together, NFC

This is to make the FIR generation interface stand out visually.

The functions in the cpp file have also been reordered to match
the header.

There are no functional changes.


  Commit: 9447dddba61ad3a5441d9b0b397bde9b5876b37d
      https://github.com/llvm/llvm-project/commit/9447dddba61ad3a5441d9b0b397bde9b5876b37d
  Author: Krzysztof Parzyszek <Krzysztof.Parzyszek at amd.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M flang/lib/Lower/FirConverter.h

  Log Message:
  -----------
  Move bodies of inline functions out of class definition, NFC

This is to make the class definition more readable. There are no
functional changes.


Compare: https://github.com/llvm/llvm-project/compare/ee75872b9840...9447dddba61a