[all-commits] [llvm/llvm-project] 3bba53: [AsmWriter] Use unsigned char more consistently

Nikita Popov via All-commits all-commits at lists.llvm.org
Fri Dec 8 07:28:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3bba53854a21177b5423f9212343ecec6316e4bf
      https://github.com/llvm/llvm-project/commit/3bba53854a21177b5423f9212343ecec6316e4bf
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2023-12-08 (Fri, 08 Dec 2023)

  Changed paths:
    M llvm/lib/IR/AsmWriter.cpp
    M llvm/test/Assembler/named-metadata.ll

  Log Message:
  -----------
  [AsmWriter] Use unsigned char more consistently

On platforms where char is signed, the ">> 4" shift will produce
incorrect results. We were already working on unsigned char for
most characters, but not for the first one.

Fixes https://github.com/llvm/llvm-project/issues/74732.




More information about the All-commits mailing list