[all-commits] [llvm/llvm-project] fa5486: [BOLT] [Passes] Fix two compile warnings in BOLT (...

Jon Roelofs via All-commits all-commits at lists.llvm.org
Wed Dec 6 13:19:18 PST 2023


  Branch: refs/heads/users/jroelofs/spr/main.clang-function-multi-versioning-supports-ifunc-lowerings-on-darwin-platforms
  Home:   https://github.com/llvm/llvm-project
  Commit: fa5486e487a6f98358eca572efb4b1fd7d27d1f5
      https://github.com/llvm/llvm-project/commit/fa5486e487a6f98358eca572efb4b1fd7d27d1f5
  Author: Ho Cheung <17492865+gz83 at users.noreply.github.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M bolt/lib/Passes/IndirectCallPromotion.cpp
    M bolt/lib/Passes/ReorderAlgorithm.cpp

  Log Message:
  -----------
  [BOLT] [Passes] Fix two compile warnings in BOLT (#73086)

Fix build issue on Windows.

issue:#73085

@maksfb PTAL thank you


  Commit: 30d700117b772d94d8474ec56bd6f9cc423fc613
      https://github.com/llvm/llvm-project/commit/30d700117b772d94d8474ec56bd6f9cc423fc613
  Author: Aiden Grossman <agrossman154 at yahoo.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M llvm/test/tools/llvm-exegesis/X86/latency/memory-annotations-unsupported.s
    R llvm/test/tools/llvm-exegesis/X86/latency/snippet-address-annotations-unsupported.s
    R llvm/test/tools/llvm-exegesis/X86/latency/subprocess-address-annotation.s
    M llvm/tools/llvm-exegesis/lib/BenchmarkResult.h
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/SnippetFile.cpp
    M llvm/tools/llvm-exegesis/llvm-exegesis.cpp
    M llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp

  Log Message:
  -----------
  Revert "[llvm-exegesis] Add in snippet address annotation (#74218)"

This reverts commit 3ab41f912a6c219a93b87c257139822ea07c8863.

Unit tests break after recent changes. Will investigate/reland.


  Commit: 69c4930aad9659ec6ab846c8e7124d6afe044b1e
      https://github.com/llvm/llvm-project/commit/69c4930aad9659ec6ab846c8e7124d6afe044b1e
  Author: Thurston Dang <thurston at google.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M llvm/lib/CodeGen/RegisterCoalescer.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/arm64-pcsections.ll
    R llvm/test/CodeGen/X86/coalescer-breaks-subreg-to-reg-liveness.ll
    M llvm/test/CodeGen/X86/coalescer-implicit-def-regression-imp-operand-assert.mir
    R llvm/test/CodeGen/X86/coalescing-subreg-to-reg-requires-subrange-update.mir
    R llvm/test/CodeGen/X86/subreg-to-reg-coalescing.mir

  Log Message:
  -----------
  Revert "Reapply "RegisterCoalescer: Add implicit-def of super register when coalescing SUBREG_TO_REG""

This reverts commit 1f283a60a4bb896fa2d37ce00a3018924be82b9f.
Reason: breaks MSan buildbot
(https://lab.llvm.org/buildbot/#/builders/74/builds/24077)


  Commit: 2f620374a05d4bfd1e8bebe97a34c9a5471553ed
      https://github.com/llvm/llvm-project/commit/2f620374a05d4bfd1e8bebe97a34c9a5471553ed
  Author: Matthew Devereau <matthew.devereau at arm.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M clang/include/clang/Basic/arm_sve.td
    M clang/lib/Sema/Sema.cpp
    M clang/test/CodeGen/aarch64-sve2p1-intrinsics/acle_sve2p1_pfalse.c
    M clang/test/CodeGen/aarch64-sve2p1-intrinsics/acle_sve2p1_ptrue.c

  Log Message:
  -----------
  Add SME2 builtins for pfalse and ptrue (#71953)

Extend pfalse and ptrue builtins with svcount_t return types to be
enabled for sve2p1 and sme2

See https://github.com/ARM-software/acle/pull/217


  Commit: f1c08eebb3bb5eb6e984bcca511381a9748c6705
      https://github.com/llvm/llvm-project/commit/f1c08eebb3bb5eb6e984bcca511381a9748c6705
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M clang/include/clang/IndexSerialization/SerializablePathCollection.h
    M clang/lib/IndexSerialization/SerializablePathCollection.cpp

  Log Message:
  -----------
  [clang] NFCI: Use `FileEntryRef::getName()` in clangIndexSerialization

The clangIndexSerialization target seems to be unused, so it didn't build when I ran `check-all` before landing d1f86c3d. This should resolve the deprecation warning that caused some build bots to fail.


  Commit: 1241b5b05b5cc2e39915a06ee679d644463dcd67
      https://github.com/llvm/llvm-project/commit/1241b5b05b5cc2e39915a06ee679d644463dcd67
  Author: Owen Pan <owenpiano at gmail.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M clang/lib/Format/TokenAnnotator.h
    M clang/lib/Format/UnwrappedLineFormatter.cpp

  Log Message:
  -----------
  [clang-format][NFC] Refactor getting first/last non-comment of line (#74570)


  Commit: c37573e8c7a6bb82901f2bf35f08efcabd78f112
      https://github.com/llvm/llvm-project/commit/c37573e8c7a6bb82901f2bf35f08efcabd78f112
  Author: LLVM GN Syncbot <llvmgnsyncbot at gmail.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/modernize/BUILD.gn

  Log Message:
  -----------
  [gn build] Port 1e1e11a4d7c5


  Commit: cd83180c60d8cf149123c881526e3905c9c49275
      https://github.com/llvm/llvm-project/commit/cd83180c60d8cf149123c881526e3905c9c49275
  Author: madanial0 <118996571+madanial0 at users.noreply.github.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M flang/test/Lower/default-initialization-globals.f90

  Log Message:
  -----------
  [flang] Change global initialization for equivalence on AIX (NFC) (#74614)

default initialization for equivalence on AIX results in a different
value due to endianness, changing the testcase to account for that.

Co-authored-by: Mark Danial <mark.danial at ibm.com>


  Commit: 3d1172813fc640514c6cb421394c34f4b42cb634
      https://github.com/llvm/llvm-project/commit/3d1172813fc640514c6cb421394c34f4b42cb634
  Author: Thurston Dang <thurston.dang at gmail.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc

  Log Message:
  -----------
  [sanitizer_common] Fix potential null dereference in dlopen interceptor (#74645)

The test_only_replace_dlopen_main_program flag
(introduced in
https://github.com/llvm/llvm-project/commit/0be4c6b9483594494051e8f1f67afc2b516270ca)
will cause internal_strcmp to dereference NULL if DlAddrSelfFName()
returns NULL (which happens in very rare cases). This patch adds a
null pointer check.

Co-authored-by: Thurston Dang <thurston at google.com>


  Commit: b4e19155171edf14412dc4132b7b10a84ac65fc5
      https://github.com/llvm/llvm-project/commit/b4e19155171edf14412dc4132b7b10a84ac65fc5
  Author: Lang Hames <lhames at gmail.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M compiler-rt/test/orc/TestCases/Darwin/x86-64/jit-re-dlopen-data-reset.S
    M compiler-rt/test/orc/TestCases/Darwin/x86-64/jit-re-dlopen-trivial.S
    M compiler-rt/test/orc/TestCases/Darwin/x86-64/trivial-jit-dlopen-nested.c
    M compiler-rt/test/orc/TestCases/Darwin/x86-64/trivial-jit-dlopen.c
    M compiler-rt/test/orc/TestCases/Linux/ppc64/trivial-atexit.S
    M compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-atexit.S
    M compiler-rt/test/orc/TestCases/Windows/x86-64/trivial-jit-dlopen.c
    M llvm/test/ExecutionEngine/JITLink/AArch32/ELF_thumbv7_printf.s
    M llvm/tools/llvm-jitlink/llvm-jitlink.cpp
    M llvm/tools/llvm-jitlink/llvm-jitlink.h

  Log Message:
  -----------
  Re-apply "[llvm-jitlink] Add Process and Platform JITDylibs, ..." with fixes.

This reapplies 3d0dd1a7d6, which was reverted in df2485b215a due to bot
failures. This patch addresses the issues seen on the bots by disabling two
Linux atexit tests in the ORC runtime whose behavior could not be maintained
now that the ORC runtime is being loaded into a separate Platform JITDylib.
https://github.com/llvm/llvm-project/issues/74641 has been filed to fix the
issue with atexit.


  Commit: 0eb7d53cfc48f2e9287bb116415620618ca850b7
      https://github.com/llvm/llvm-project/commit/0eb7d53cfc48f2e9287bb116415620618ca850b7
  Author: Julian Schmidt <44101708+5chmidti at users.noreply.github.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
    M clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp
    A clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp
    A clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.h
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/docs/clang-tidy/checks/list.rst
    A clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-numbers.rst
    A clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-numbers.cpp

  Log Message:
  -----------
  [clang-tidy] add modernize-use-std-numbers (#66583)

Finds constants and function calls to math functions that can be
replaced with c++20's mathematical constants from the 'numbers' 
header and offers fix-it hints.
Does not match the use of variables with that value, and instead,
offers a replacement at the definition of those variables.


  Commit: e1fa2fea03ff94627008054267a244744d76b5c2
      https://github.com/llvm/llvm-project/commit/e1fa2fea03ff94627008054267a244744d76b5c2
  Author: Piotr Zegar <me at piotrzegar.pl>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp

  Log Message:
  -----------
  [clang-tidy][NFC] Change ArrayRef into std::vector in modernize-use-std-numbers

To avoid compiler errors on some platforms introduced
by #66583, now using std::vector to pass list of
matchers into main matcher, and removed static variable
as it could introduce some other issues.


  Commit: 81360ec58217c42b288d1267aba4836f880b19ba
      https://github.com/llvm/llvm-project/commit/81360ec58217c42b288d1267aba4836f880b19ba
  Author: Oskar Wirga <10386631+oskarwirga at users.noreply.github.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M llvm/lib/Transforms/IPO/LowerTypeTests.cpp
    M llvm/test/Transforms/LowerTypeTests/aarch64-jumptable.ll
    A llvm/test/Transforms/LowerTypeTests/cfi-nounwind-direct-call.ll
    A llvm/test/Transforms/LowerTypeTests/cfi-unwind-direct-call.ll
    M llvm/test/Transforms/LowerTypeTests/function-arm-thumb.ll
    M llvm/test/Transforms/LowerTypeTests/function-thumb-bti.ll
    M llvm/test/Transforms/LowerTypeTests/function.ll
    M llvm/test/Transforms/LowerTypeTests/x86-jumptable.ll

  Log Message:
  -----------
  [CFI] Fix Direct Call Issues in CFI Dispatch Table (#69663)

I discovered two issues for when a CFI dispatch table entry is used as a
direct call.
# Inlining
There is the possibility that the dispatch table entry contains only a
single function pointer:
```
; Function Attrs: naked nocf_check
define private void @.cfi.jumptable() #6 align 8 { entry:
  call void asm sideeffect "jmp ${0:c}@plt\0Aint3\0Aint3\0Aint3\0A", "s"(ptr @_Z7throw_ei)
  unreachable
}
```
If this function is inlined, the unreachable follows and ruins the
containing function.
# Exception Handling
The dispatch table is always marked NoUnwind. This is fine if the
entries are never used directly, but if a direct call is used which the
containing function expects to throw, it will no longer throw and the
exception handling code will be lost.


  Commit: 48ca868dd3f803cd8c500475e5880652bad75815
      https://github.com/llvm/llvm-project/commit/48ca868dd3f803cd8c500475e5880652bad75815
  Author: LLVM GN Syncbot <llvmgnsyncbot at gmail.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/modernize/BUILD.gn

  Log Message:
  -----------
  [gn build] Port 0eb7d53cfc48


  Commit: 90adaa8a709e016032cb31775f717ca6e0cd21b7
      https://github.com/llvm/llvm-project/commit/90adaa8a709e016032cb31775f717ca6e0cd21b7
  Author: Jon Roelofs <jonathan_roelofs at apple.com>
  Date:   2023-12-06 (Wed, 06 Dec 2023)

  Changed paths:
    M bolt/lib/Passes/IndirectCallPromotion.cpp
    M bolt/lib/Passes/ReorderAlgorithm.cpp
    M clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
    M clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp
    A clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp
    A clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.h
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/docs/clang-tidy/checks/list.rst
    A clang-tools-extra/docs/clang-tidy/checks/modernize/use-std-numbers.rst
    A clang-tools-extra/test/clang-tidy/checkers/modernize/use-std-numbers.cpp
    M clang/include/clang/Basic/arm_sve.td
    M clang/include/clang/IndexSerialization/SerializablePathCollection.h
    M clang/lib/Format/TokenAnnotator.h
    M clang/lib/Format/UnwrappedLineFormatter.cpp
    M clang/lib/IndexSerialization/SerializablePathCollection.cpp
    M clang/lib/Sema/Sema.cpp
    M clang/test/CodeGen/aarch64-sve2p1-intrinsics/acle_sve2p1_pfalse.c
    M clang/test/CodeGen/aarch64-sve2p1-intrinsics/acle_sve2p1_ptrue.c
    M compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
    M compiler-rt/test/orc/TestCases/Darwin/x86-64/jit-re-dlopen-data-reset.S
    M compiler-rt/test/orc/TestCases/Darwin/x86-64/jit-re-dlopen-trivial.S
    M compiler-rt/test/orc/TestCases/Darwin/x86-64/trivial-jit-dlopen-nested.c
    M compiler-rt/test/orc/TestCases/Darwin/x86-64/trivial-jit-dlopen.c
    M compiler-rt/test/orc/TestCases/Linux/ppc64/trivial-atexit.S
    M compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-atexit.S
    M compiler-rt/test/orc/TestCases/Windows/x86-64/trivial-jit-dlopen.c
    M flang/test/Lower/default-initialization-globals.f90
    M llvm/lib/CodeGen/RegisterCoalescer.cpp
    M llvm/lib/Transforms/IPO/LowerTypeTests.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/arm64-pcsections.ll
    R llvm/test/CodeGen/X86/coalescer-breaks-subreg-to-reg-liveness.ll
    M llvm/test/CodeGen/X86/coalescer-implicit-def-regression-imp-operand-assert.mir
    R llvm/test/CodeGen/X86/coalescing-subreg-to-reg-requires-subrange-update.mir
    R llvm/test/CodeGen/X86/subreg-to-reg-coalescing.mir
    M llvm/test/ExecutionEngine/JITLink/AArch32/ELF_thumbv7_printf.s
    M llvm/test/Transforms/LowerTypeTests/aarch64-jumptable.ll
    A llvm/test/Transforms/LowerTypeTests/cfi-nounwind-direct-call.ll
    A llvm/test/Transforms/LowerTypeTests/cfi-unwind-direct-call.ll
    M llvm/test/Transforms/LowerTypeTests/function-arm-thumb.ll
    M llvm/test/Transforms/LowerTypeTests/function-thumb-bti.ll
    M llvm/test/Transforms/LowerTypeTests/function.ll
    M llvm/test/Transforms/LowerTypeTests/x86-jumptable.ll
    M llvm/test/tools/llvm-exegesis/X86/latency/memory-annotations-unsupported.s
    R llvm/test/tools/llvm-exegesis/X86/latency/snippet-address-annotations-unsupported.s
    R llvm/test/tools/llvm-exegesis/X86/latency/subprocess-address-annotation.s
    M llvm/tools/llvm-exegesis/lib/BenchmarkResult.h
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/SnippetFile.cpp
    M llvm/tools/llvm-exegesis/llvm-exegesis.cpp
    M llvm/tools/llvm-jitlink/llvm-jitlink.cpp
    M llvm/tools/llvm-jitlink/llvm-jitlink.h
    M llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp

  Log Message:
  -----------
  [𝘀𝗽𝗿] changes introduced through rebase

Created using spr 1.3.4

[skip ci]


Compare: https://github.com/llvm/llvm-project/compare/c515a9dd8099...90adaa8a709e


More information about the All-commits mailing list