[all-commits] [llvm/llvm-project] e8dbe9: TargetInstrInfo, TargetSchedule: fix non-NFC parts...
Ramkumar Ramachandra via All-commits
all-commits at lists.llvm.org
Tue Dec 5 00:18:31 PST 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: e8dbe945f39f2249fe24e0d62ec8ac998e853c2b
https://github.com/llvm/llvm-project/commit/e8dbe945f39f2249fe24e0d62ec8ac998e853c2b
Author: Ramkumar Ramachandra <Ramkumar.Ramachandra at imgtec.com>
Date: 2023-12-05 (Tue, 05 Dec 2023)
Changed paths:
M llvm/lib/CodeGen/TargetInstrInfo.cpp
M llvm/lib/CodeGen/TargetSchedule.cpp
M llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
Log Message:
-----------
TargetInstrInfo, TargetSchedule: fix non-NFC parts of 9468de4 (#74338)
Follow up on a post-commit review of 9468de4 (TargetInstrInfo: make
getOperandLatency return optional (NFC)) by Bjorn Pettersson to fix a
couple of things that are not NFC:
- std::optional<T>::operator<= returns true if the first operand is a
std::nullopt and second operand is T. Fix a couple of places where we
assumed it would return false.
- In TargetSchedule, computeInstrCost could take another codepath,
returning InstrLatency instead of DefaultDefLatency. Fix one instance
not accounting for this behavior.
More information about the All-commits
mailing list