[all-commits] [llvm/llvm-project] 3dae97: [mlir][bufferization] Fix op dominance bug in rewr...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3dae97cc011ca097bd457bbfa5855da86290f631
      https://github.com/llvm/llvm-project/commit/3dae97cc011ca097bd457bbfa5855da86290f631
  Author: Matthias Springer <me at m-sp.org>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M mlir/lib/Dialect/Bufferization/Transforms/BufferDeallocationSimplification.cpp

  Log Message:
  -----------
  [mlir][bufferization] Fix op dominance bug in rewrite pattern (#74159)

Fixes a bug in `SplitDeallocWhenNotAliasingAnyOther`. This pattern used
to generate invalid IR (op dominance error). We never noticed this bug
in existing test cases because other patterns and/or foldings were
applied afterwards and those rewrites "fixed up" the IR again. (The bug
is visible when running `mlir-opt -debug`.) Also add additional comments
to the implementation and simplify the code a bit.

Apart from the fixed dominance error, this change is NFC. Without this
change, buffer deallocation tests will fail when running with #74270.