[all-commits] [llvm/llvm-project] ccfc2d: [mlir][transform] Remove `cachedNames` expensive c...

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ccfc2d687c106ee8430fccd09e165e0aaea39081
      https://github.com/llvm/llvm-project/commit/ccfc2d687c106ee8430fccd09e165e0aaea39081
  Author: Matthias Springer <me at m-sp.org>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M mlir/include/mlir/Dialect/Transform/IR/TransformInterfaces.h
    M mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp

  Log Message:
  -----------
  [mlir][transform] Remove `cachedNames` expensive check (#73961)

This check was trying to find cases of invalid API usage:
incorrect/missing handle side effects and/or incorrect rewriter usage.

This check is not implemented correctly and can report false positives
in case of pointer reuse (different op created at same location). It is
unclear if such a check can be implemented given that we have both
tracking listener-based handle updates and handle consumption.

Fixes #72931.