[all-commits] [llvm/llvm-project] 5a4ca5: [mlir] notify insertion of parent op first when cl...

[jeanPerier via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a4ca51a91ff28b1d6bdde5403144c29b86e4b54
      https://github.com/llvm/llvm-project/commit/5a4ca51a91ff28b1d6bdde5403144c29b86e4b54
  Author: jeanPerier <jperier at nvidia.com>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M mlir/lib/IR/Builders.cpp
    M mlir/test/IR/test-clone.mlir
    M mlir/test/lib/IR/TestClone.cpp

  Log Message:
  -----------
  [mlir] notify insertion of parent op first when cloning (#73806)

When cloning an operation with a region, the builder was currently
notifying about the insertion of the cloned operations inside the region
before the cloned operation itself.

When using cloning inside rewrite pass, this could cause issues if a
pattern is expected to be applied on a cloned parent operation before
trying to apply patterns on the cloned operations it contains (the
patterns are attempted in order of notifications for the cloned
operations).