[all-commits] [llvm/llvm-project] 2ee876: [test] Fix expected line number in `TestRunner.py`...

Stephan T. Lavavej via All-commits all-commits at lists.llvm.org
Thu Nov 30 15:06:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2ee8763fecad644c1b25bfdb06a884d291633009
      https://github.com/llvm/llvm-project/commit/2ee8763fecad644c1b25bfdb06a884d291633009
  Author: Stephan T. Lavavej <stl at nuwen.net>
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
    M llvm/utils/lit/tests/unit/TestRunner.py

  Log Message:
  -----------
  [test] Fix expected line number in `TestRunner.py` (#73996)

My #73541 added lines to
`llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt` so what
was previously on line 7 is now on line 12.

Before:

https://github.com/llvm/llvm-project/blob/28412d1800e391c5ba8e7607bb15c74b106d581b/llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt#L7-L8

After:

https://github.com/llvm/llvm-project/blob/6fb7c2d713587a061cd281eda917746750559380/llvm/utils/lit/tests/Inputs/testrunner-custom-parsers/test.txt#L12-L13

This didn't show up in the PR checks, but caused a buildbot failure
after merging, https://lab.llvm.org/buildbot/#/builders/139/builds/54597
:

```
# | ======================================================================
# | FAIL: test_commands (__main__.TestIntegratedTestKeywordParser)
# | ----------------------------------------------------------------------
# | Traceback (most recent call last):
# |   File "/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/utils/lit/tests/unit/TestRunner.py", line 135, in test_commands
# |     self.assertEqual(value[1].command.strip(), "%dbg(MY_RUN: at line 7)  foo  bar")
# | AssertionError: '%dbg(MY_RUN: at line 12)  foo  bar' != '%dbg(MY_RUN: at line 7)  foo  bar'
# | - %dbg(MY_RUN: at line 12)  foo  bar
# | ?                      ^^
# | + %dbg(MY_RUN: at line 7)  foo  bar
# | ?                      ^
```

Apologies for the build break :scream_cat:




More information about the All-commits mailing list