[all-commits] [llvm/llvm-project] 13386c: [clang][DependencyScanner] Include the working dir...

Michael Spencer via All-commits all-commits at lists.llvm.org
Thu Nov 30 12:47:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 13386c608e6d571d2d91eea5f7c8fb6911d6dcfb
      https://github.com/llvm/llvm-project/commit/13386c608e6d571d2d91eea5f7c8fb6911d6dcfb
  Author: Michael Spencer <bigcheesegs at gmail.com>
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
    M clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp
    A clang/test/ClangScanDeps/working-dir.m

  Log Message:
  -----------
  [clang][DependencyScanner] Include the working directory in the context hash (#73719)

The working directory is included in the PCM, but is not currently part
of the context hash. This causes problems because different builds of a
PCM with exactly the same command line can end up with different binary
content for a PCM. If a build system tracks tasks by both working
directory and command line, it may build a given PCM multiple times,
causing a "module file out of date" error when loading the PCM due to
different sizes.




More information about the All-commits mailing list