[all-commits] [llvm/llvm-project] cc84a1: [libc] fix getchar_unlocked (#73874)

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Thu Nov 30 12:38:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cc84a1419723fcc240c3c6832bdb990afef37f4b
      https://github.com/llvm/llvm-project/commit/cc84a1419723fcc240c3c6832bdb990afef37f4b
  Author: Nick Desaulniers <nickdesaulniers at users.noreply.github.com>
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
    M libc/src/stdio/generic/CMakeLists.txt

  Log Message:
  -----------
  [libc] fix getchar_unlocked (#73874)

A typo was leading to getc_unlocked.cpp.o being included into libc.a
twice.

I only noticed because I was trying to convert libc.a to a shared object
via

$ ld.lld -o libc.so --whole-archive libc.a

which errored since getc_unlocked was being defined twice.




More information about the All-commits mailing list