[all-commits] [llvm/llvm-project] 2eff36: Revert "[CodeGen] Port SafeStack to new pass manag...

[Shubham Sandeep Rastogi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2eff36b7d33fb9ea5c15ea8561fe6b30105d48f5
      https://github.com/llvm/llvm-project/commit/2eff36b7d33fb9ea5c15ea8561fe6b30105d48f5
  Author: Shubham Sandeep Rastogi <srastogi22 at apple.com>
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
    R llvm/include/llvm/CodeGen/SafeStack.h
    M llvm/lib/CodeGen/SafeStack.cpp
    M llvm/lib/Passes/PassBuilder.cpp
    M llvm/lib/Passes/PassRegistry.def
    M llvm/test/Transforms/SafeStack/AArch64/abi.ll
    M llvm/test/Transforms/SafeStack/AArch64/abi_ssp.ll
    M llvm/test/Transforms/SafeStack/AArch64/unreachable.ll
    M llvm/test/Transforms/SafeStack/ARM/abi.ll
    M llvm/test/Transforms/SafeStack/ARM/debug.ll
    M llvm/test/Transforms/SafeStack/ARM/setjmp.ll
    M llvm/test/Transforms/SafeStack/X86/abi.ll
    M llvm/test/Transforms/SafeStack/X86/abi_ssp.ll
    M llvm/test/Transforms/SafeStack/X86/addr-taken.ll
    M llvm/test/Transforms/SafeStack/X86/array-aligned.ll
    M llvm/test/Transforms/SafeStack/X86/array.ll
    M llvm/test/Transforms/SafeStack/X86/byval.ll
    M llvm/test/Transforms/SafeStack/X86/call.ll
    M llvm/test/Transforms/SafeStack/X86/cast.ll
    M llvm/test/Transforms/SafeStack/X86/coloring-ssp.ll
    M llvm/test/Transforms/SafeStack/X86/coloring.ll
    M llvm/test/Transforms/SafeStack/X86/coloring2.ll
    M llvm/test/Transforms/SafeStack/X86/constant-gep-call.ll
    M llvm/test/Transforms/SafeStack/X86/constant-gep.ll
    M llvm/test/Transforms/SafeStack/X86/constant-geps.ll
    M llvm/test/Transforms/SafeStack/X86/debug-loc-dynamic.ll
    M llvm/test/Transforms/SafeStack/X86/debug-loc.ll
    M llvm/test/Transforms/SafeStack/X86/debug-loc2.ll
    M llvm/test/Transforms/SafeStack/X86/dynamic-alloca.ll
    M llvm/test/Transforms/SafeStack/X86/escape-addr-pointer.ll
    M llvm/test/Transforms/SafeStack/X86/escape-bitcast-store.ll
    M llvm/test/Transforms/SafeStack/X86/escape-bitcast-store2.ll
    M llvm/test/Transforms/SafeStack/X86/escape-call.ll
    M llvm/test/Transforms/SafeStack/X86/escape-casted-pointer.ll
    M llvm/test/Transforms/SafeStack/X86/escape-gep-call.ll
    M llvm/test/Transforms/SafeStack/X86/escape-gep-invoke.ll
    M llvm/test/Transforms/SafeStack/X86/escape-gep-negative.ll
    M llvm/test/Transforms/SafeStack/X86/escape-gep-ptrtoint.ll
    M llvm/test/Transforms/SafeStack/X86/escape-gep-store.ll
    M llvm/test/Transforms/SafeStack/X86/escape-phi-call.ll
    M llvm/test/Transforms/SafeStack/X86/escape-select-call.ll
    M llvm/test/Transforms/SafeStack/X86/escape-vector.ll
    M llvm/test/Transforms/SafeStack/X86/invoke.ll
    M llvm/test/Transforms/SafeStack/X86/layout-frag.ll
    M llvm/test/Transforms/SafeStack/X86/layout-region-split.ll
    M llvm/test/Transforms/SafeStack/X86/memintrinsic-oob-read.ll
    M llvm/test/Transforms/SafeStack/X86/musttail.ll
    M llvm/test/Transforms/SafeStack/X86/no-attr.ll
    M llvm/test/Transforms/SafeStack/X86/no-crash-on-lifetime.ll
    M llvm/test/Transforms/SafeStack/X86/phi-cycle.ll
    M llvm/test/Transforms/SafeStack/X86/phi.ll
    M llvm/test/Transforms/SafeStack/X86/pr54784.ll
    M llvm/test/Transforms/SafeStack/X86/ret.ll
    M llvm/test/Transforms/SafeStack/X86/setjmp.ll
    M llvm/test/Transforms/SafeStack/X86/setjmp2.ll
    M llvm/test/Transforms/SafeStack/X86/sink-to-use.ll
    M llvm/test/Transforms/SafeStack/X86/ssp.ll
    M llvm/test/Transforms/SafeStack/X86/store.ll
    M llvm/test/Transforms/SafeStack/X86/struct.ll

  Log Message:
  -----------
  Revert "[CodeGen] Port SafeStack to new pass manager (#73747)" (#73965)

This reverts commit a4d5fd4d2ee9470e55345a9540f6b6fb6faf66e1.

The above commit breaks greendragon lldb bots:
Link to failing builds:
https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/63300/
https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/10345/

I found this PR to be the offending one after using git bisect with the
cmake invocation:

cmake -G Ninja ../llvm -DCMAKE_BUILD_TYPE=Release
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON
'-DLLVM_TARGETS_TO_BUILD=X86;ARM;AArch64'
-DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE
-DLLVM_ENABLE_MODULES=On
-DLLVM_ENABLE_PROJECTS='clang;lld;lldb;cross-project-tests'
-DLLVM_VERSION_PATCH=99
'-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi;compiler-rt'

and running
ninja lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CodeGenPassBuilder.cpp.o