[all-commits] [llvm/llvm-project] 442490: [DebugInfo][RemoveDIs] Handle DPValues at remainin...

[Jeremy Morse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 442490315685944b71037bccc410048fb3612060
      https://github.com/llvm/llvm-project/commit/442490315685944b71037bccc410048fb3612060
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2023-11-30 (Thu, 30 Nov 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/lib/Transforms/Scalar/JumpThreading.cpp
    M llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
    M llvm/test/DebugInfo/Generic/mem2reg-promote-alloca-1.ll
    M llvm/test/DebugInfo/Generic/mem2reg-promote-alloca-2.ll
    M llvm/test/DebugInfo/Generic/mem2reg-promote-alloca-3.ll
    M llvm/test/DebugInfo/Generic/volatile-alloca.ll
    M llvm/test/DebugInfo/X86/mem2reg_fp80.ll
    M llvm/test/Transforms/InstCombine/cast-set-preserve-signed-dbg-val.ll
    M llvm/test/Transforms/InstCombine/consecutive-fences.ll
    M llvm/test/Transforms/InstCombine/dbg-scalable-store-fixed-frag.ll
    M llvm/test/Transforms/InstCombine/debuginfo-dce2.ll
    M llvm/test/Transforms/InstCombine/debuginfo-skip.ll
    M llvm/test/Transforms/InstCombine/debuginfo.ll
    M llvm/test/Transforms/InstCombine/debuginfo_add.ll
    M llvm/test/Transforms/InstCombine/erase-dbg-values-at-dead-alloc-site.ll
    M llvm/test/Transforms/InstCombine/lower-dbg-declare.ll
    M llvm/test/Transforms/InstCombine/pr43893.ll
    M llvm/test/Transforms/InstCombine/sink-instruction-introduces-unnecessary-poison-value.ll
    M llvm/test/Transforms/InstCombine/stacksave-debuginfo.ll
    M llvm/test/Transforms/InstCombine/unavailable-debug.ll

  Log Message:
  -----------
  [DebugInfo][RemoveDIs] Handle DPValues at remaining dbg.value using sites (#73788)

This patch updates the last few places in LLVM using findDbgValues that
don't also collect and handle DPValue objects. This largely involves
instcombine and mem2reg changes, and are largely mechanical, calling
existing utilities on collections of DPValues instead of just
DbgValuesInsts.

A variety of tests have had RemoveDIs RUN lines added to them to cover
these behaviours. We have some technical debt of the instcombine sinking
code for DPValues not being implemented yet, so I've left FIXME stubs
indicating that we intend to cover tests with RemoveDIs but haven't yet.