[all-commits] [llvm/llvm-project] 2c0718: [LEB128] Don't initialize error on success

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2c07181424b45d0785002b760f9ab404b7506b57
      https://github.com/llvm/llvm-project/commit/2c07181424b45d0785002b760f9ab404b7506b57
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M lld/COFF/Driver.cpp
    M lld/ELF/Driver.cpp
    M llvm/include/llvm/Support/LEB128.h
    M llvm/lib/Object/MachOObjectFile.cpp
    M llvm/lib/Support/DataExtractor.cpp
    M llvm/tools/llvm-readobj/COFFDumper.cpp
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [LEB128] Don't initialize error on success

This change removes an unnecessary branch from a hot path. It's also
questionable API to override any previous error unconditonally.


  Commit: 643f25fb1d0b2153e8684354968ad358cc0e3f53
      https://github.com/llvm/llvm-project/commit/643f25fb1d0b2153e8684354968ad358cc0e3f53
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Support/LEB128.h

  Log Message:
  -----------
  [LEB128] Factor out redundant code


  Commit: 963b186951ec9b8babb924ebda6a9f193a6269c8
      https://github.com/llvm/llvm-project/commit/963b186951ec9b8babb924ebda6a9f193a6269c8
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Support/LEB128.h

  Log Message:
  -----------
  [LEB128] Don't handle edge cases in every loop iteration

Previously the overflow check was done for every byte even though it
is only needed for the case where Shift == 63.


  Commit: efa1d0d641c770267ff4c523a450334cd24ebe15
      https://github.com/llvm/llvm-project/commit/efa1d0d641c770267ff4c523a450334cd24ebe15
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Support/LEB128.h

  Log Message:
  -----------
  [LEB128] Mark error condition with LLVM_UNLIKELY


Compare: https://github.com/llvm/llvm-project/compare/076bd22f579e...efa1d0d641c7