[all-commits] [llvm/llvm-project] 545c8e: [LEB128] Don't initialize error on success

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 545c8e009e2b649ef38f7e432ffbc06ba8a9b813
      https://github.com/llvm/llvm-project/commit/545c8e009e2b649ef38f7e432ffbc06ba8a9b813
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M lld/COFF/Driver.cpp
    M lld/ELF/Driver.cpp
    M llvm/include/llvm/Support/LEB128.h
    M llvm/lib/Object/MachOObjectFile.cpp
    M llvm/lib/Support/DataExtractor.cpp
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [LEB128] Don't initialize error on success

This change removes an unnecessary branch from a hot path. It's also
questionable API to override any previous error unconditonally.


  Commit: b96121c2e7de66154a70db5f202c9adce515aa45
      https://github.com/llvm/llvm-project/commit/b96121c2e7de66154a70db5f202c9adce515aa45
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Support/LEB128.h

  Log Message:
  -----------
  [LEB128] Factor out redundant code


  Commit: 0cc2acc30b3d2f4e914fd49c599cfde8a17f26a6
      https://github.com/llvm/llvm-project/commit/0cc2acc30b3d2f4e914fd49c599cfde8a17f26a6
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Support/LEB128.h

  Log Message:
  -----------
  [LEB128] Don't handle edge cases in every loop iteration

Previously the overflow check was done for every byte even though it
is only needed for the case where Shift == 63.


  Commit: 80fc872a24c4dca4820d2e7885b5ee9195bec42a
      https://github.com/llvm/llvm-project/commit/80fc872a24c4dca4820d2e7885b5ee9195bec42a
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M llvm/include/llvm/Support/LEB128.h

  Log Message:
  -----------
  [LEB128] Mark error condition with LLVM_UNLIKELY


Compare: https://github.com/llvm/llvm-project/compare/792253ae0ef3...80fc872a24c4