[all-commits] [llvm/llvm-project] d2d9dc: [DebugInfo][RemoveDIs] Make debugify pass convert ...

[Jeremy Morse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d2d9dc8eb4126271ee1406c2586a4953db831d21
      https://github.com/llvm/llvm-project/commit/d2d9dc8eb4126271ee1406c2586a4953db831d21
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M llvm/lib/Transforms/Utils/Debugify.cpp
    M llvm/test/Transforms/ArgumentPromotion/pr27568.ll
    M llvm/test/Transforms/BDCE/basic.ll
    M llvm/test/Transforms/DCE/basic.ll
    M llvm/test/Transforms/DeadStoreElimination/debuginfo.ll
    M llvm/test/Transforms/GlobalOpt/shrink-global-to-bool-check-debug.ll
    M llvm/test/Transforms/InstCombine/call-guard.ll
    M llvm/test/Transforms/InstCombine/cast-mul-select.ll
    M llvm/test/Transforms/InstCombine/debuginfo-variables.ll
    M llvm/test/Transforms/InstCombine/double-float-shrink-2.ll
    M llvm/test/Transforms/InstCombine/storemerge-dbg.ll
    M llvm/test/Transforms/JumpThreading/branch-debug-info.ll
    M llvm/test/Transforms/LCSSA/avoid-intrinsics-in-catchswitch.ll
    M llvm/test/Transforms/LCSSA/basictest.ll
    M llvm/test/Transforms/LICM/sinking-debugify.ll
    M llvm/test/Transforms/LoopIdiom/X86/arithmetic-right-shift-until-zero.ll
    M llvm/test/Transforms/LoopIdiom/X86/left-shift-until-bittest.ll
    M llvm/test/Transforms/LoopIdiom/X86/logical-right-shift-until-zero-debuginfo.ll
    M llvm/test/Transforms/LoopIdiom/memcpy-debugify-remarks.ll
    M llvm/test/Transforms/LoopIdiom/memset-debugify-remarks.ll
    M llvm/test/Transforms/LoopUnroll/X86/call-remark.ll
    M llvm/test/Transforms/LoopVectorize/i8-induction.ll
    M llvm/test/Transforms/LoopVectorize/preserve-dbg-loc-and-loop-metadata.ll
    M llvm/test/Transforms/Mem2Reg/PromoteMemToRegister.ll
    M llvm/test/Transforms/MemCpyOpt/pr37967.ll
    M llvm/test/Transforms/MergedLoadStoreMotion/st_sink_check_debug.ll
    M llvm/test/Transforms/SCCP/ipsccp-basic.ll
    M llvm/test/Transforms/SCCP/loadtest.ll
    M llvm/test/Transforms/SROA/alignment.ll
    M llvm/test/Transforms/SimplifyCFG/X86/merge-compatible-invokes-of-landingpad-debuginfo.ll
    M llvm/test/Transforms/SimplifyCFG/debug-info-thread-phi.ll
    M llvm/test/Transforms/TailCallElim/debugloc.ll
    M llvm/test/Transforms/Util/Debugify/loc-only.ll

  Log Message:
  -----------
  [DebugInfo][RemoveDIs] Make debugify pass convert to/from RemoveDIs mode (#73251)

Debugify is extremely useful as a testing and debugging tool, and a good
number of LLVM-IR transform tests use it. We need it to support "new"
non-instruction debug-info to get test coverage, but it's not important
enough to completely convert right now (and it'd be a large
undertaking). Thus: convert to/from dbg.value/DPValue mode on entry and
exit of the pass, which gives us the functionality without any further
work. The cost is compile-time, but again this is only happening during
tests.

Tested by: the large set of debugify tests enabled here. Note the
InstCombine test (cast-mul-select.ll) that hasn't been fully enabled:
this is because there's a debug-info sinking piece of code there that
hasn't been instrumented.