[all-commits] [llvm/llvm-project] ea6404: Revert "[llvm] Disable HandleLLVMOptions in runtim...

[Hans via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ea640472a2f1b851a5edf653c5257767d7fedd70
      https://github.com/llvm/llvm-project/commit/ea640472a2f1b851a5edf653c5257767d7fedd70
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M runtimes/CMakeLists.txt

  Log Message:
  -----------
  Revert "[llvm] Disable HandleLLVMOptions in runtimes mode (#73031)"

This appears to have caused a variety of breakages, see comments on the PR.

> Summary:
> There are a few default options that LLVM adds that can be problematic
> for runtimes builds. These options are generally intended to handle
> building LLVM itself, but are also added when building in a runtimes
> mode. One such issue I've run into is that in `libc` we deliberately use
> `--target` to use a different device toolchain, which doesn't support
> some linker arguments passed via `-Wl`. This is observed in
> https://github.com/llvm/llvm-project/pull/73030 when attempting to use
> these options.
>
> This patch completely removes these default arguments.
>
> The consensus is that any issues created by this patch should ultimately
> be solved on a per-runtime basis.

This reverts commit ee922e6ebfb6aab722f6b0f7cfc0c20af636a250.