[all-commits] [llvm/llvm-project] b0af8a: Revert "[lldb] [mostly NFC] Large WP foundation: W...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b0af8a1ede89e87f737f2a31b6a2e2491e38ac04
      https://github.com/llvm/llvm-project/commit/b0af8a1ede89e87f737f2a31b6a2e2491e38ac04
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M lldb/include/lldb/Breakpoint/BreakpointSite.h
    A lldb/include/lldb/Breakpoint/BreakpointSiteList.h
    R lldb/include/lldb/Breakpoint/StopPointSiteList.h
    M lldb/include/lldb/Breakpoint/Watchpoint.h
    R lldb/include/lldb/Breakpoint/WatchpointResource.h
    R lldb/include/lldb/Breakpoint/WatchpointResourceList.h
    M lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h
    M lldb/include/lldb/Target/Process.h
    M lldb/include/lldb/lldb-defines.h
    M lldb/include/lldb/lldb-forward.h
    M lldb/include/lldb/lldb-types.h
    M lldb/source/API/SBThread.cpp
    M lldb/source/API/SBWatchpoint.cpp
    M lldb/source/Breakpoint/BreakpointLocation.cpp
    M lldb/source/Breakpoint/BreakpointSite.cpp
    A lldb/source/Breakpoint/BreakpointSiteList.cpp
    M lldb/source/Breakpoint/CMakeLists.txt
    R lldb/source/Breakpoint/StopPointSiteList.cpp
    M lldb/source/Breakpoint/Watchpoint.cpp
    R lldb/source/Breakpoint/WatchpointResource.cpp
    R lldb/source/Breakpoint/WatchpointResourceList.cpp
    M lldb/source/Commands/CommandObjectProcess.cpp
    M lldb/source/Commands/CommandObjectWatchpoint.cpp
    M lldb/source/Interpreter/OptionGroupWatchpoint.cpp
    M lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
    M lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
    M lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h
    M lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp
    M lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
    M lldb/source/Plugins/Process/Windows/Common/ProcessWindows.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
    M lldb/source/Target/Platform.cpp
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/StackFrameList.cpp
    M lldb/source/Target/StopInfo.cpp
    M lldb/source/Target/Target.cpp
    M lldb/source/Target/ThreadPlanCallFunction.cpp
    M lldb/source/Target/ThreadPlanStepOut.cpp
    M lldb/source/Target/ThreadPlanStepRange.cpp
    M lldb/source/Target/ThreadPlanStepUntil.cpp
    M lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
    M lldb/test/Shell/Watchpoint/Inputs/val.c
    M lldb/test/Shell/Watchpoint/LocalVariableWatchpointDisabler.test
    M lldb/test/Shell/Watchpoint/SetErrorCases.test

  Log Message:
  -----------
  Revert "[lldb] [mostly NFC] Large WP foundation: WatchpointResources (#68845)"

...and follow ups.

As it has caused test failures on Linux Arm and AArch64:
https://lab.llvm.org/buildbot/#/builders/96/builds/49126
https://lab.llvm.org/buildbot/#/builders/17/builds/45824

```
  lldb-shell :: Subprocess/clone-follow-child-wp.test
  lldb-shell :: Subprocess/fork-follow-child-wp.test
  lldb-shell :: Subprocess/vfork-follow-child-wp.test
```

This reverts commit a6c62bf1a4717accc852463b664cd1012237d334,
commit a0a1ff3ab40e347589b4e27d8fd350c600526735 and commit
fc6b72523f3d73b921690a713e97a433c96066c6.