[all-commits] [llvm/llvm-project] 3247f1: [mlir][affine] Fix dim index out of bounds crash (...

[Rik Huijzer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3247f1e7a281184ac0db4fc6df35232e8f1a4f12
      https://github.com/llvm/llvm-project/commit/3247f1e7a281184ac0db4fc6df35232e8f1a4f12
  Author: Rik Huijzer <github at huijzer.xyz>
  Date:   2023-11-28 (Tue, 28 Nov 2023)

  Changed paths:
    M mlir/lib/Dialect/Affine/IR/AffineOps.cpp
    M mlir/test/Conversion/FuncToSPIRV/func-ops-to-spirv.mlir
    M mlir/test/Dialect/Affine/invalid.mlir
    M mlir/test/Dialect/Affine/load-store-invalid.mlir

  Log Message:
  -----------
  [mlir][affine] Fix dim index out of bounds crash (#73266)

This PR suggests a way to fix
https://github.com/llvm/llvm-project/issues/70418. It now throws an
error if the `index` operand for `memref.dim` is out of bounds. Catching
it in the verifier was not possible because the constant value is not
yet available at that point. Unfortunately, the error is not very
descriptive since it was only possible to propagate boolean up.